4.4 API issue: Plasma::Animation::setWidgetToAnimate

2010-01-03 Thread Aaron J. Seigo
hi all .. doing some last minute API grooming here and noticed that we have Plasma::Animation::setWidgetToAnimate while Qt has QVariantAnimation::setTargetObject. proposal: changed setWidgetToAnimate to setTargetWidget, for consistency. thoughts? -- Aaron J. Seigo humru othro a kohnu se GPG

Re: 4.4 API issue: Plasma::Animation::setWidgetToAnimate

2010-01-03 Thread Igor Trindade Oliveira
hi, agreed. Igor --- Em seg, 4/1/10, Aaron J. Seigo escreveu: > De: Aaron J. Seigo > Assunto: 4.4 API issue: Plasma::Animation::setWidgetToAnimate > Para: plasma-devel@kde.org > Data: Segunda-feira, 4 de Janeiro de 2010, 1:41 > hi all .. > > doing some last minute

Re: 4.4 API issue: Plasma::Animation::setWidgetToAnimate

2010-01-03 Thread Chani
On January 3, 2010 19:41:19 Aaron J. Seigo wrote: > hi all .. > > doing some last minute API grooming here and noticed that we have > Plasma::Animation::setWidgetToAnimate while Qt has > QVariantAnimation::setTargetObject. > > proposal: changed setWidgetToAnimate to setTargetWidget, for consisten

Re: 4.4 API issue: Plasma::Animation::setWidgetToAnimate

2010-01-03 Thread Akmanalp, Mehmet A
On Sun, Jan 3, 2010 at 10:41 PM, Aaron J. Seigo wrote: > hi all .. > > doing some last minute API grooming here and noticed that we have > Plasma::Animation::setWidgetToAnimate while Qt has > QVariantAnimation::setTargetObject. Hah, missed this entirely! > proposal: changed setWidgetToAnimate to

Re: 4.4 API issue: Plasma::Animation::setWidgetToAnimate

2010-01-04 Thread Marco Martin
On Monday 04 January 2010, Aaron J. Seigo wrote: > hi all .. > > doing some last minute API grooming here and noticed that we have > Plasma::Animation::setWidgetToAnimate while Qt has > QVariantAnimation::setTargetObject. > > proposal: changed setWidgetToAnimate to setTargetWidget, for consistenc

Re: 4.4 API issue: Plasma::Animation::setWidgetToAnimate

2010-01-04 Thread Aaron J. Seigo
On January 3, 2010, Aaron J. Seigo wrote: > proposal: changed setWidgetToAnimate to setTargetWidget, for consistency. ok, committed. rebuilding base, addons and examples to catch all effected code and committing fixes as i go. btw, i also made the following two changes: * setTargetWidget is not