D28389: Add support for logging categories

This revision was automatically updated to reflect the committed changes. Closed by commit R133:c103ceb1caf0: Add support for logging categories (authored by romangg). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28389?vs=78881&id=79092 REVI

D28465: [Categories Page] Use BasicListItem

broulik added a comment. > Tablet mode spacing should just be added into BasicListItem itself Agreed. I was surprised it didn't actually come from it but was done here explicitly REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28465 To: broulik, #plasma

D28465: [Categories Page] Use BasicListItem

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! Tablet mode spacing should just be added into BasicListItem itself, if it doesn't already have it. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D

D28465: [Categories Page] Use BasicListItem

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The delegate doesn't have its own appearance anymore, so just use the default one. TEST PLAN L

D28389: Add support for logging categories

romangg added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:23 > Make sure the include() call is before the add_subdirectory(). > > That's why we usually put them together on top right under the find_package() > together with `include(ECMGenerateHeaders)`. Put the include on

D28389: Add support for logging categories

romangg updated this revision to Diff 78881. romangg added a comment. Include the cpp files REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28389?vs=78765&id=78881 BRANCH logging-categories REVISION DETAIL https://phabricator.kde.org/D2

D28389: Add support for logging categories

apol added a comment. Other than that, the patch looks good. +1 INLINE COMMENTS > romangg wrote in CMakeLists.txt:23 > Any idea how to reuse the declaration from the top-directory CMake file? Make sure the include() call is before the add_subdirectory(). That's why we usually put them toget

D28389: Add support for logging categories

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:23 > +Critical > +) > + Any idea how to reuse the declaration from the top-directory CMake file? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28389 To: romangg, #plasma Cc: plasma-devel,

D28389: Add support for logging categories

current uncategorized messages with categorized ones in these parts. TEST PLAN Tested messages with autotests and QT_LOGGING_RULES="kscreenlocker*=true". REPOSITORY R133 KScreenLocker BRANCH logging-categories REVISION DETAIL https://phabricator.kde.org/D28389 AFFE

D27915: Use breeze icons for categories

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a6e8f3bc52a: Use breeze icons for categories (authored by Guo Yunhe <i...@guoyunhe.me>). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27915?vs=77

D27915: Use breeze icons for categories

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Don't land before D27913 . REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27915 To: guoyunhe, #plasma, apo

D27915: Use breeze icons for categories

ngraham added a reviewer: apol. ngraham added a comment. Hmm, your before and after screenshots look identical to me. What's the reason for this? To make them look better in High DPI mode? I thought that was already fixed with D27515: Icon: fix rendering of image: urls on High DPI

D27915: Use breeze icons for categories

to compare the left panel. > > > Yes there is still a difference in the left panel in my screenshot compared to your before screenshot. Not pixelated and all categories colorful The "pixelated" icon only appears to HiDPI display. The "monochrome" icon onl

D27915: Use breeze icons for categories

for me: > > F8163706: Screenshot_20200307_171017.PNG <https://phabricator.kde.org/F8163706> > > > Please ignore the content. I only want to compare the left panel. Yes there is still a difference in the left panel in my screenshot compared to your before screensh

D27915: Use breeze icons for categories

guoyunhe added a comment. In D27915#623854 , @davidre wrote: > There is something wrong on your system, this is how before looks for me: > F8163706: Screenshot_20200307_171017.PNG Please ignore th

D27915: Use breeze icons for categories

davidre added a comment. There is something wrong on your system, this is how before looks for me: F8163706: Screenshot_20200307_171017.PNG REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27915 To: guoyunhe, #plasma Cc

D27915: Use breeze icons for categories

guoyunhe updated this revision to Diff 77174. guoyunhe added a comment. Change object-group to object REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27915?vs=77172&id=77174 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27915 AFFEC

D27915: Use breeze icons for categories

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27915 AFFECTED FILES applets/kimpanel/backend/ib

D26021: Display sub categories when searching

This revision was automatically updated to reflect the committed changes. Closed by commit R124:f82cca0cb07f: Display sub categories when searching (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71889&id=71890 REVI

D26021: Display sub categories when searching

mart updated this revision to Diff 71889. mart added a comment. - root categories are 0 depth REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71881&id=71889 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D2

D26021: Display sub categories when searching

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in MenuModel.cpp:49 > In other models we tend to drop the suffix "Role" from the rolename > > i.e Qt::DisplayRole -> "display" > > but it's not super important. I followed what it was doing previously, MenuItemRols->MenuItem wo

D26021: Display sub categories when searching

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > MenuModel.cpp:49 > > +QHash MenuModel::roleNames() const > +{ In other models we tend to drop the suffix "Role" from the rolename i.e Qt::DisplayRole

D26021: Display sub categories when searching

mart updated this revision to Diff 71881. mart added a comment. - remove trailing space REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71880&id=71881 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021 AFFECTED

D26021: Display sub categories when searching

mart updated this revision to Diff 71880. mart added a comment. - switch column when there are two REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71876&id=71880 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021

D26021: Display sub categories when searching

mart updated this revision to Diff 71876. mart added a comment. - don't accept invalid index as root - select proper category when not in search more REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71803&id=71876 BRANCH arcpatch-D26021

D26021: Display sub categories when searching

mart updated this revision to Diff 71803. mart added a comment. - Pleased code enter the commit message for your changes. Lines starting REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71799&id=71803 BRANCH arcpatch-D26021 REVISION DETAI

D26021: Display sub categories when searching

ngraham added inline comments. INLINE COMMENTS > MenuModel.cpp:25 > #include > - > +#include > #include "MenuItem.h" Remove > CategoriesPage.qml:149 > +//icon: model.decoration > +//label: model.display > separatorVisible: false Remove REPOSITORY R12

D26021: Display sub categories when searching

mart added a comment. In D26021#579771 , @ngraham wrote: > Nice! > > Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png > > It used to be white

D26021: Display sub categories when searching

mart updated this revision to Diff 71799. mart added a comment. - white text when selected - lways load the module when in search mode REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71776&id=71799 BRANCH arcpatch-D26021 REVISION DETAI

D26021: Display sub categories when searching

mart added a comment. In D26021#579771 , @ngraham wrote: > Nice! > > Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png > > It used to be white

D26021: Display sub categories when searching

ngraham added a comment. Nice! Somehow this has regressed the text color for the selected item: F7824037: Screenshot_20191218_064325.png It used to be white before this patch. REPOSITORY R124 System Settings REVISION DETAIL https://phabric

D26021: Display sub categories when searching

mart updated this revision to Diff 71776. mart added a comment. - get rid of the const cast REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71775&id=71776 BRANCH arcpatch-D26021 REVISION DETAIL https://phabricator.kde.org/D26021 AFFEC

D26021: Display sub categories when searching

mart marked 2 inline comments as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in SidebarMode.cpp:400 > please check validity, otherwise model is null and we'll crash. > > also ..why make it const, only to cast it? got rif of the cast REPOSITORY R124 System Setting

D26021: Display sub categories when searching

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in SidebarMode.cpp:400 > please check validity, otherwise model is null and we'll crash. > > also ..why make it const, only to cast it? QModelIndex::index() is always const? REPOSITORY R124 System Settings REVISION DETAIL

D26021: Display sub categories when searching

mart updated this revision to Diff 71775. mart marked 3 inline comments as done. mart added a comment. - adress comments - fix clicking againthe same category REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71614&id=71775 BRANCH arcpatc

D26021: Display sub categories when searching

davidedmundson added inline comments. INLINE COMMENTS > MenuModel.cpp:102 > +MenuItem *candidate = mi->parent(); > +while ( candidate && candidate->parent() && > candidate->parent()->parent() ) { > +candidate = candidate->parent(); More comments are neede

D26021: Display sub categories when serching

mart updated this revision to Diff 71614. mart added a comment. - hide subcategory column when going back to start page REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26021?vs=71613&id=71614 BRANCH mart/newSearch REVISION DETAIL https://phabri

D26021: Display sub categories when serching

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when searching, show categories *and* subcategories indented under categories, making it way less

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

This revision was automatically updated to reflect the committed changes. Closed by commit R124:a81d0ca787d7: Draw categories in iconview in a similiar style as Kirigami and new… (authored by davidre). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

GB_2 added a comment. In D24533#544784 , @filipf wrote: > This sort of a style, the line is right next to the title. > > F7567596: image.png Hmm, I think that would be too inconsistent again. Curr

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

filipf added a comment. In D24533#544773 , @ngraham wrote: > Do you mean the equivalent of a column layout, with a horizontal line under the title? This sort of a style, the line is right next to the title. F7567596: image.png

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

ngraham added a comment. Do you mean the equivalent of a column layout, with a horizontal line under the title? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D24533 To: davidre, #plasma, #vdg Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, j

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

filipf added a comment. Looks good to me, although a little bit empty. If I was designing this in a vacuum I would add the equivalent of a row layout, put the label in it and then a separator after it. What do you think, would it be too inconsistent with our other header style? REPOSITORY

D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D24533 AFFECTED FILES icons/CategoryDrawer.cpp i

D23267: Fix log categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:98d3b607ee35: Fix log categories file (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64049&id=64050 REVISION DETAIL h

D23267: Fix log categories file

meven updated this revision to Diff 64049. meven added a comment. Fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64047&id=64049 BRANCH arcpatch-D23267 REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED FILES plas

D23267: Fix log categories file

meven updated this revision to Diff 64047. meven added a comment. Do not touch ksmserver line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23267?vs=64046&id=64047 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED FI

D23267: Fix log categories file

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23267 AFFECTED FIL

D22888: Prefer categories with the query string visible in results

This revision was automatically updated to reflect the committed changes. Closed by commit R112:aa9e1d6c3f15: Prefer categories with the query string visible in results (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22888?vs=62959&am

D22888: Prefer categories with the query string visible in results

higher priority than likely more useful application results with the given name. It only affects the order of categories, e.g. scoring "Applications" higher than "Documents" if such a match exists. The order of matches within a category is untouched and remains determined by

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in KNSBackend.cpp:214 > I think we can use the icon `plugins` here. Submit a patch! :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D22716 To: leinir, #discover_software_store, #vdg, ngraham

D18417: Adjust and remove some top-level categories to implement new Appearance section layout

This revision was automatically updated to reflect the committed changes. Closed by commit R124:b4bd5b465511: Adjust and remove some top-level categories to implement new Appearance section… (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18417?vs=49966&id=62922

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

GB_2 added inline comments. INLINE COMMENTS > KNSBackend.cpp:214 > }; > -auto actualCategory = new Category(m_displayName, > QStringLiteral("plasma"), filters, backendName, categories, QUrl(), true); > +const auto iconName = knsr

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

This revision was automatically updated to reflect the committed changes. Closed by commit R134:29fb6ce9e369: Add icons to Categories, Installed, and Sources globaldrawer entries (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome! I've wanted this for a long time. LGTM. We can tweak the icons and their assignments in subsequent patches if necessary. REPOSITORY R134 Discover Software Store BRANCH more-

D22716: Add icons to Categories, Installed, and Sources globaldrawer entries

. This is furthermore based on feedback from the Plasma Mobile Todo[1] notes entry, which at time of writing contains the following (amongst others): Discover: Global toolbar: - Installed and Sources should have icons - Categories should either have icons or be less indented [1

D19925: Split up subcategories for KNS categories

This revision was automatically updated to reflect the committed changes. Closed by commit R134:29be60b13647: Split up subcategories for KNS categories (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19925?vs=55813&id=55881#toc REPOSITORY R134 Discover Soft

D19925: Split up subcategories for KNS categories

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM otherwise INLINE COMMENTS > KNSBackend.cpp:149 > +const QString catName = cat->name().append(QLatin1Char('/')); > +for (auto& p

D19925: Split up subcategories for KNS categories

leinir updated this revision to Diff 55813. leinir marked an inline comment as done. leinir added a comment. Remove unnecessary (very noisy) debug messages REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19925?vs=54446&id=55813 REVISION DETA

D19925: Split up subcategories for KNS categories

leinir planned changes to this revision. leinir added inline comments. INLINE COMMENTS > KNSBackend.cpp:149 > +const QString catName = cat->name().append(QLatin1Char('/')); > +qDebug() << "Checking" << catName; > +for (auto

D19925: Split up subcategories for KNS categories

leinir added a comment. Ping? :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19925 To: leinir, #discover_software_store, apol, ngraham Cc: plasma-devel, #discover_software_store, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, lesliez

D19925: Split up subcategories for KNS categories

functionality to programmatically add subcategories (with a suitable warning not to do so after the initialisation stage), and uses that to perform a splitting of the subcategories supplied the KNewStuff backend. TEST PLAN Previously: Many categories, with annoying and bad readability With patch: A

D19682: Set colorSet on categories header

This revision was automatically updated to reflect the committed changes. Closed by commit R124:441697ca9b81: Set colorSet on categories header (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19682?vs=53656&id=53657#toc REPOSITORY R124 System Settings CHA

D19682: Set colorSet on categories header

back button on the sub categories page did not. This adds an explicit color set like was done on the sub categories page. TEST PLAN Should probably go into 5.12 since the code was there for the sub categories page already and distros tend to ship newer Frameworks with Plasma LTS Before

D18417: Adjust and remove some top-level categories to implement new Appearance section layout [2/3]

on in T8871: Systematic KCM reorganisation <https://phabricator.kde.org/T8871>. In this patch, the ordering of some categories is changed, and the top-level Workspace Theme category is removed. TEST PLAN F6558679: New appearance section <https://phabricator.kde.org/F6558679>

D17005: Fix dismissing the Dashboard by clicking inbetween multi-grid categories.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e12e3cad1d7e: Fix dismissing the Dashboard by clicking inbetween multi-grid categories. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D17005: Fix dismissing the Dashboard by clicking inbetween multi-grid categories.

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Or on category headers. BUG:400720 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17005 AF

D16403: Add services and appstream runner debug categories to categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:17a0d34d0e83: Add services and appstream runner debug categories to categories file (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D16403: Add services and appstream runner debug categories to categories file

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Make the debug categories visible in kdebugsettings REPOSITORY R120 Plasma Workspace BRANCH

D13357: Use logging categories in a few dataengines

rikmills added a comment. @davidedmundson Seems so. Thank you. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13357 To: davidedmundson, #plasma, mart Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seba

D13357: Use logging categories in a few dataengines

davidedmundson added a comment. Thanks. Hopefully fixed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13357 To: davidedmundson, #plasma, mart Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D13357: Use logging categories in a few dataengines

rikmills added a comment. Build errors with this: https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/44/console https://build.neon.kde.org/job/bionic_unstable_kde_plasma-workspace/102/ https://kci.pangea.pub/job/cosmic_unstable_plasma-workspace/ 13:4

D13357: Use logging categories in a few dataengines

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a8573d1be5a4: Use logging categories in a few dataengines (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13357?vs=35598&am

D13357: Use logging categories in a few dataengines

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH

D12774: Fix submenus not updating when switching between categories of the same size

hein added a comment. No worries, also my fault for not spotting it in review. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12774 To: hein, #plasma, mart Cc: dfaure, rikmills, ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D12774: Fix submenus not updating when switching between categories of the same size

dfaure added a comment. Oops, thanks for the fix. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12774 To: hein, #plasma, mart Cc: dfaure, rikmills, ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D12774: Fix submenus not updating when switching between categories of the same size

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c0cd1f8d49e6: Fix submenus not updating when switching between categories of the same size (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D12774: Fix submenus not updating when switching between categories of the same size

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This fixes a regression introduced in 38403268aad3 , wh

D11842: Remove categories from app delegates

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:0911fbcd561c: Remove categories from app delegates (authored by ngraham). REPOSITORY R134 Discover Soft

D11842: Remove categories from app delegates

ngraham added a comment. Patch to bump the version required: D12035: Bump KF5 version requirement to 5.45 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11842 To: ngraham, apol, #discover_software_store Cc: rkflx

D11842: Remove categories from app delegates

ngraham added a comment. In D11842#241862 <https://phabricator.kde.org/D11842#241862>, @rkflx wrote: > FWIW, have a +1 for the idea. Removing the categories is not ideal, but having the ratings can be much more enticing for the user to install the app, and there is only so m

D11842: Remove categories from app delegates

rkflx added a comment. FWIW, have a +1 for the idea. Removing the categories is not ideal, but having the ratings can be much more enticing for the user to install the app, and there is only so much space… Thus I think it's the better compromise to go with the ratings. ---

D11842: Remove categories from app delegates

ngraham updated this revision to Diff 31109. ngraham added a comment. Rebase on master REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11842?vs=31054&id=31109 BRANCH remove-categories-on-delegates (branched from master) REVISION DE

D11842: Remove categories from app delegates

s and certain views, they sometimes don't show up at all, which is confusing and inconsistent TEST PLAN Looks better: [images go here] REPOSITORY R134 Discover Software Store BRANCH remove-categories-on-delegates (branched from master) REVISION DETAIL https://phabricator.kde.

D10622: Add multimedia sub-categories

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10622 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10622: Add multimedia sub-categories

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH more-multimedia-categories (branched from master) REVISION DETAIL https://phabricator.kde.org/D10622 To: ngraham, #discover_software_store, apol Cc: plasma-devel

D10622: Add multimedia sub-categories

;id=27441 BRANCH more-multimedia-categories (branched from master) REVISION DETAIL https://phabricator.kde.org/D10622 AFFECTED FILES libdiscover/backends/FlatpakBackend/flatpak-backend-categories.xml libdiscover/backends/PackageKitBackend/packagekit-backend-categories.xml To

D10622: Add multimedia sub-categories

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10622 To: ngraham, #discover_software_store, apol Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10622: Add multimedia sub-categories

Neon. The top 10-15 entries in each category are good, but the Audio Players and Video Players categories have far too many items as a result of poor app category tagging. Further work is needed to reduce these lists to manageable levels, but hopefully this is better than nothing for now

D9065: [Task Manager] Support places categories

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6effcdf11d1a: [Task Manager] Support places categories (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9065?vs=23165&id=2

D9065: [Task Manager] Support places categories

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9065 To: broulik, #plasma, hein, #vdg, renatoo Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D9065: [Task Manager] Support places categories

broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9065 To: broulik, #plasma, hein, #vdg, renatoo Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9065: [Task Manager] Support places categories

broulik created this revision. broulik added reviewers: Plasma, hein, VDG, renatoo. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds submenus for subsequent categories in places model. Now that baloo search and

D8350: Add categories in gallery desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R169:68382196a5ef: Add categories in gallery desktop file (authored by arojas). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8350?vs=20924&id=20930 REVISION DE

D8350: Add categories in gallery desktop file

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8350 To: arojas, mart, apol Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D8350: Add categories in gallery desktop file

arojas created this revision. arojas added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 385430 TEST PLAN The gallery application appears in the Development section instead of "Lost and Found

D5605: Allow multiple categories with the same name

This revision was automatically updated to reflect the committed changes. Closed by commit R304:36f23700babd: Allow multiple categories with the same name (authored by mart). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5605?vs=14070&id=14103 REVI

D5605: Allow multiple categories with the same name

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH arcpatch-D5605 REVISION DETAIL https://phabricator.kde.org/D5605 To: mart, #plasma, leinir, whiting, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, spsta

D5605: Allow multiple categories with the same name

mart updated this revision to Diff 14070. mart added a comment. - remove empty placeholders REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5605?vs=13843&id=14070 BRANCH arcpatch-D5605 REVISION DETAIL https://phabricator.kde.org/D5605 AFFECTED FILES

D5605: Allow multiple categories with the same name

> +mCategoryMap.insertMulti(category.name(), category); > mCategoryMap is pre-populated with null categories in the constructor. This looks like this now won't ever update them. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5605 To: mart, #plasm

  1   2   >