broulik added inline comments.
INLINE COMMENTS
> main.qml:56
> +tasksModel.requestToggleMinimized(idx);
> +clients.push(tasksModel.makePersistentModelIndex(i));
> +}
This method does not exist, did you forget to commit the plasma-workspace part?
REPOS
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:c8c734fabe47: Port minimize all applet from it's own
plugin to org.kde.TaskManager (authored by davidedmundson).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
anthonyfieroni accepted this revision.
anthonyfieroni added a comment.
This revision is now accepted and ready to land.
It looks good to me.
REPOSITORY
R114 Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10019
To: davidedmundson, #plasma, anthonyfieroni
Cc: n
davidedmundson updated this revision to Diff 27364.
davidedmundson added a comment.
Track window changes
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10019?vs=25753&id=27364
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10019
AFF
davidedmundson planned changes to this revision.
davidedmundson added a comment.
Good point.
Will revisit.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D10019
To: davidedmundson, #plasma
Cc: anthonyfieroni, sebas, broulik, plasma-devel, ZrenBot, progwolff,
anthonyfieroni added a comment.
Thats what doubt me:
https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/minimizeall/plugin/minimizeall.cpp;65fc80441388c5f3e70832c40e1d7afea6778e83$63-68
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D10
sebas added a comment.
I like, getting rid of C++ code is always welcome.
Once the patch to libtaskmanager is in and kbroulik's comments addressed, +2
from my side.
Thanks!
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D10019
To: davidedmundson, #pl
broulik added a comment.
Don't you also need to remove the cpp stuff from CMakeLists and what not?
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D10019
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreu
broulik added a comment.
BUG: 377213
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D10019
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik added a comment.
Cool!
INLINE COMMENTS
> main.qml:57
> +tasksModel.requestToggleMinimized(idx);
> +clients.push(tasksModel.makePeristentModelndex(i));
> +}
typo
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabric
davidedmundson updated this revision to Diff 25753.
davidedmundson added a comment.
Debug--
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10019?vs=25752&id=25753
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10019
AFFECTED FILES
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
This reduces the code we have and implicitly
12 matches
Mail list logo
