D10131: Expose more URLs relevant to the app

ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26062. ngraham added a comment. "Make a Donation" -> "Donate" REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26033&id=26062 BRANCH more-URLs REVISION DETAIL https://phabricator.kde.org/D10

D10131: Expose more URLs relevant to the app

ngraham marked 2 inline comments as done. REPOSITORY R134 Discover Software Store BRANCH more-URLs REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10131: Expose more URLs relevant to the app

ngraham added inline comments. INLINE COMMENTS > apol wrote in ApplicationPage.qml:347 > Donation:? Donate:? > > "Make a donation" reads a bit too long to me for such a title. "Donate: sounds good. "Make a Donation:" would probably be 4 lines long in German, anyway. :) REPOSITORY R134 Disco

D10131: Expose more URLs relevant to the app

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Other than that, LGTM. INLINE COMMENTS > ApplicationPage.qml:347 > +Layout.alignment: Qt.AlignRight > +text: i18n("Make a Donation:") > +} Donation:

D10131: Expose more URLs relevant to the app

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26033. ngraham added a comment. Fix unintentional whitespace change REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26032&id=26033 BRANCH more-URLs REVISION DETAIL https://phabricator.kde.o

D10131: Expose more URLs relevant to the app

ngraham marked 2 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26032. ngraham added a comment. Be smarter about how we find and display the links REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10131?vs=26024&id=26032 BRANCH more-URLs REVISION DETAIL https://p

D10131: Expose more URLs relevant to the app

apol added inline comments. INLINE COMMENTS > ApplicationPage.qml:39 > +readonly property string donationURL: application.donationURL > +readonly property string version: appInfo.application.isInstalled ? > appInfo.application.installedVersion : appInfo.application.availableVersion > +

D10131: Expose more URLs relevant to the app

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham marked 3 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham updated this revision to Diff 26024. ngraham added a comment. - Don't create unnecessary stub functions - Don't unnecessarily re-define variables ApplicationPage.qml - Show all the new URLs by default (when available) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UP

D10131: Expose more URLs relevant to the app

apol added inline comments. INLINE COMMENTS > ApplicationPage.qml:337 > +readonly property string helpURL: application.helpURL > +visible: helpURL.length > 0 > +text: helpURL No need to put it in a separte property. And specially don't add the exac

D10131: Expose more URLs relevant to the app

apol added inline comments. INLINE COMMENTS > AbstractResource.h:134 > +///@returns a URL that points to the app's online documentation > +virtual QUrl helpURL() = 0; > +///@returns a URL that points to the place where you can file a bug Maybe they could return an empty u

D10131: Expose more URLs relevant to the app

ngraham added a comment. (for master, since it includes a string change) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10131: Expose more URLs relevant to the app

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10131 To: ngraham, apol, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10131: Expose more URLs relevant to the app

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Make the help, bug tracker, and donation URL