This revision was automatically updated to reflect the committed changes.
Closed by commit R116:e1673f18e942: Adjust spacing between text and plotter
line in Speed tab of nm applet (authored by kamathraghavendra, committed by
nicolasfella).
REPOSITORY
R116 Plasma Network Management Applet
jgrulich accepted this revision.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D10183
To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich, ngraham
Cc: ngraham, plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai,
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
QML and presentation look great to me!
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D10183
To: kamathraghavendra, davidedmundson,
kamathraghavendra added inline comments.
INLINE COMMENTS
> davidedmundson wrote in TrafficMonitor.qml:55
> Semantically it's weird to use the size of an icon for a margin, unless
> you're trying to line up with an icon. There's a medium sized icon in the
> toolbar, which I assume is the intent
kamathraghavendra updated this revision to Diff 26190.
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10183?vs=26185=26190
REVISION DETAIL
https://phabricator.kde.org/D10183
AFFECTED FILES
applet/contents/ui/TrafficMonitor.qml
davidedmundson added a comment.
Looks good. +1
1 minor nitpick, but it's not super important.
INLINE COMMENTS
> TrafficMonitor.qml:55
> left: parent.left
> -leftMargin: units.iconSizes.medium
> +leftMargin: units.iconSizes.large
> right:
kamathraghavendra added reviewers: Plasma, broulik, jgrulich.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D10183
To: kamathraghavendra, davidedmundson, #plasma, broulik, jgrulich
Cc: plasma-devel, davidedmundson, ZrenBot, progwolff,
kamathraghavendra added a reviewer: davidedmundson.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D10183
To: kamathraghavendra, davidedmundson
Cc: plasma-devel, davidedmundson, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
kamathraghavendra created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kamathraghavendra requested review of this revision.
REVISION SUMMARY
The text showing the speed of the download in the speed section of the
