D10263: Fix being unable to close the toolbox menu by clicking outside

GB_2 added a comment. Can be abandoned because of D24265 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: GB_2, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D10263: Fix being unable to close the toolbox menu by clicking outside

ngraham added a comment. Cannot reproduce the issue myself with either Folder View or Desktop. There must be some case where it's reproducible though... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: ngraham, broulik,

D10263: Fix being unable to close the toolbox menu by clicking outside

hein added a comment. Yup. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10263: Fix being unable to close the toolbox menu by clicking outside

mart added a comment. still can't reproduce the popup not closing when clicking on empty areas of desktop, does the problem persists for you? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To: hein, #plasma, mart Cc: broulik, plasma-devel, ZrenBot,

D10263: Fix being unable to close the toolbox menu by clicking outside

hein added a comment. Empty desktop doesn't close it for me without this patch. This was based on a user bug report. It was almost the first thing they saw / struggled with when using Plasma for the first time. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10263: Fix being unable to close the toolbox menu by clicking outside

mart added a comment. update: for me on master the toolbox menu is already closed both when clicking on an empty desktop area or another window, but not the applet handles or borders, as it should REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To:

D10263: Fix being unable to close the toolbox menu by clicking outside

mart added a comment. opening the toolbox enables an "edit mode" which opens all applet handles, they should continue to be interactible, so hideOnWindowDeactivate is probably not going to be enough, but would need more complex interaction (ie the desktop containment itself closing it when

D10263: Fix being unable to close the toolbox menu by clicking outside

broulik added a comment. Can you verify the toolbox stays open while interacting with applets? If so, +1, otherwise this defies the purpose of the "edit mode" but I trust you tested exactly this :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10263 To:

D10263: Fix being unable to close the toolbox menu by clicking outside

hein created this revision. hein added reviewers: Plasma, mart. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This also sort of broke using ESC to close, because that's what users try next, but after clicking on the desktop the dialog