ngraham planned changes to this revision.
ngraham added a comment.
Still doesn't actually work right; need to hack on it more.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi
ngraham updated this revision to Diff 48569.
ngraham marked an inline comment as done.
ngraham added a comment.
Rebase on current master, address review comments, fix bugs
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
ngraham commandeered this revision.
ngraham added a reviewer: lshoravi.
ngraham added a comment.
I'll finish this.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi
Cc:
ngraham added a comment.
@lshoravi are you willing and able to address the above-mentioned issues, or
should someone else comandeer the revision and do it themselves?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To: lshoravi, #plasma,
davidedmundson added a comment.
Please also fill in the testing done field.
INLINE COMMENTS
> tooltip.cpp:162
> +dlg->SetAutoShowHide(m_autoShowHide);
> +connect(dlg, :.containtsMouseChanged, this,
> ::toolTipWindowContainsMouseChangedSlot);
> dlg->setVisible(true);
doing a
aacid requested changes to this revision.
aacid added a comment.
This revision now requires changes to proceed.
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
The code doesn't merge, and after fixing that manually that the code doesn't
build
ngraham added a comment.
FYI Linus doesn't have a developer account, so someone will need to commit
this for him.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D10304
REVISION DETAIL
https://phabricator.kde.org/D10305
To: lshoravi, #plasma, #plasma_accessibility, mart
lshoravi updated this revision to Diff 26574.
lshoravi added a comment.
And with that said, I specified the wrong revision in arc. This should be the
correct diff.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10305?vs=26573=26574
lshoravi updated this revision to Diff 26573.
lshoravi edited the summary of this revision.
lshoravi added a comment.
Updated author as per ngrahams suggestion. Diff updated for latest framework
(assuming that it turned out correctly.)
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST
lshoravi edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To: lshoravi, #plasma, #plasma_accessibility, cfeck
Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff,
lesliezhai,
lshoravi edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To: lshoravi, #plasma, #plasma_accessibility, cfeck
Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff,
lesliezhai,
cfeck requested changes to this revision.
cfeck added a comment.
This revision now requires changes to proceed.
Please use the summary to describe what the patch does, not why you added it.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10305
To:
cfeck retitled this revision from "Framework patch: Moving the mouse over a
different application icon immediately changes the window list" to "Fix "Moving
the mouse over a different application icon immediately changes the window
list"".
cfeck edited the summary of this revision.
REPOSITORY
13 matches
Mail list logo
