D10383: Fix pinning apps when their .desktop file has a space in the file name.

mart added a comment. any update on this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10383 To: hein, #plasma, broulik, ivan Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10383: Fix pinning apps when their .desktop file has a space in the file name.

hein added a comment. In D10383#203804 , @ngraham wrote: > Is this expected to fully fix https://bugs.kde.org/show_bug.cgi?id=385942? No, because the reporters there used the ticket for multiple distinct issues. D10405

D10383: Fix pinning apps when their .desktop file has a space in the file name.

hein added a comment. @ivan Could you suggest a good testcase? I'm a bit wary of pushing this into the LTS branch with a low amount of confidence. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10383 To: hein, #plasma, broulik, ivan Cc: ngraham,

D10383: Fix pinning apps when their .desktop file has a space in the file name.

ngraham added a comment. Is this expected to fully fix https://bugs.kde.org/show_bug.cgi?id=385942? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10383 To: hein, #plasma, broulik, ivan Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10383: Fix pinning apps when their .desktop file has a space in the file name.

ivan added a comment. I can not say with certainty - never tested html encoding, but I would expect it to work in general. The potential problem might be that sqlite part might consider "hello world" and "hello%20world" to be different. REPOSITORY R120 Plasma Workspace REVISION

D10383: Fix pinning apps when their .desktop file has a space in the file name.

hein added a reviewer: ivan. hein added a comment. Ivan, could you weigh in on the KActivities spaces angle? INLINE COMMENTS > broulik wrote in startuptasksmodel.cpp:208 > `QUrl::toPercentEncoding` encodes *all* UTF-8 characters and slashes and what > not whereas in `toString` you only tell

D10383: Fix pinning apps when their .desktop file has a space in the file name.

broulik added a comment. > Is rejecting scheme-less URLs going to break anything? I think we're doing a quite good job of ensuring we have a `file:` or other scheme, so this //should'nt// cause behavior changes. > Can we be confident QUrl::operator== will abstract over this?

D10383: Fix pinning apps when their .desktop file has a space in the file name.

hein created this revision. hein added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Things I have concerns about with this patch and would appreciate thoughtful input on: - To get URLs through