D10425: Improve appearance of the logout dialog on wayland

2018-02-11 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4d7c1345b784: Improve appearance of the logout dialog on wayland (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10425?vs=26891=26920

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10425 To: fvogt, #plasma, graesslin, davidedmundson, bshah Cc: ngraham, bshah, plasma-devel, ZrenBot,

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Fabian Vogt
fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10425 To: fvogt, #plasma, graesslin, davidedmundson, bshah Cc: ngraham, bshah, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Fabian Vogt
fvogt updated this revision to Diff 26891. fvogt added a comment. Use a different workaround: wl-shell instead of xdg-shell. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10425?vs=26874=26891 BRANCH Plasma/5.12 REVISION DETAIL

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D10425#204000, @fvogt wrote: > In https://phabricator.kde.org/D10425#203972, @graesslin wrote: > > > I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug. > > > Is the

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D10425#203972, @graesslin wrote: > I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug. Is the referenced patch enough to make it work? AFAICT it would also need a change in

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug. Let's not work around Qt bugs: https://bugreports.qt.io/browse/QTBUG-63748

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Fabian Vogt
fvogt added a comment. > OSD might work, but those don't normally accept input. "normally" = "it shouldn't, but when testing it it does accept input just fine" @graesslin is it a bug that `setRole(OnScreenDisplay);` makes it work exactly like on X11 on wayland? i.e. is it

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Bhushan Shah
bshah accepted this revision as: bshah. bshah added a comment. +1 from me, if you want wait for review from others. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10425 To: fvogt, #plasma, graesslin, davidedmundson, bshah Cc: ngraham, bshah, plasma-devel,

D10425: Improve appearance of the logout dialog on wayland

2018-02-10 Thread Fabian Vogt
fvogt retitled this revision from "Fix appearance of the logout dialog on wayland" to "Improve appearance of the logout dialog on wayland". fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL