broulik closed this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10461
To: broulik, #plasma, mart, davidedmundson
Cc: davidedmundson, mart, rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts,
broulik updated this revision to Diff 28838.
broulik added a comment.
Fix UTF8_STRING atom type check
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10461?vs=28836=28838
REVISION DETAIL
https://phabricator.kde.org/D10461
AFFECTED FILES
broulik updated this revision to Diff 28836.
broulik added a comment.
- Fix leaks
- Cleanup
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10461?vs=28320=28836
REVISION DETAIL
https://phabricator.kde.org/D10461
AFFECTED FILES
broulik marked 5 inline comments as done.
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in icons.cpp:24
> does this list come from anywhere?
It was done trial and error by running couple of gtk apps (gedit, gimp,
inkscape, shotwell) etc, the kde 4 appmenu also had
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Fundamental design seems fine.
It's a massive patchset, I'm not sure I've got my head round all of it yet, I
might take a second round when these minor things
mart accepted this revision as: mart.
mart added a comment.
This revision is now accepted and ready to land.
looks good to me, partial shipit, is so big that i think is better if another
one reviews it too
INLINE COMMENTS
> window.cpp:288
> +} else {
> +emit LayoutUpdated(2
broulik edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10461
To: broulik, #plasma
Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
broulik updated this revision to Diff 28255.
broulik edited the test plan for this revision.
broulik added a comment.
- Split icon mapping into dedicated namespace and extend it a lot
- Monitor menus right away so we know if there's actually a menu
(appmenu-gtk-module always claims to have
rilian added a comment.
UPD: disabled an exporting of empty menubar on X11. Try latest
appmenu-gtk-module master, please.
I do not know how to do it in GTK Wayland.
Can you explain me KDE Wayland Global Menu architecture?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
rilian added a comment.
If you need help, I will provide it for you, because for me there is 2
features which should be in KDE for me:
1. Global Menu (for all protocols)
2. QGtkStyle (with GTK3 themes)
> Okay. Problem is that for example LibreOffice doesn't have a menu right
broulik added a comment.
Thanks for your input!
> Yes, menubar may be empty
Okay. Problem is that for example LibreOffice doesn't have a menu right away,
so I can't realy tell "no menu because it's still loading" or "no menu because
it doesn't have one" and then fallback to app
rilian added a comment.
What about FIXME unity, what are you mean? I can fix appmenu-gtk-module for
you.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10461
To: broulik, #plasma
Cc: rk, rilian, mtallur, ngraham, plasma-devel, ZrenBot, progwolff,
rilian added a comment.
O, some another note: You can generate menubar from appmenu.
For example, Nautilus:
It have 4 sections
1. New Window
2. Sidebar
3. Preferences
4. Keyboard Shortcuts Help About Quit.
You can add New Window and Quit to File menu, Sidebar to View,
rilian added a comment.
1. Yes, menubar may be empty with appmenu-gtk-module or unity-gtk-module, and
if I can fix appmenu-gtk-module, unity-gtk-module will not be fixed. So, I
think it is preferred to check on your side.
2. GTK3 applications (file-roller, for example) can use both appmenu
broulik added a comment.
> So, Unity is dead, but unity action prefixes is live.
I just added support for that but I don't know what apps use it to test it,
if you may..? :)
> To use unity-gtk-module or appmenu-gtk-module you need to install it into
correct location (where all gtk
broulik updated this revision to Diff 27142.
broulik edited the test plan for this revision.
broulik added a comment.
- Support unity actions (untested)
- Don't mandate actions to be present, it's perfectly valid for a window to
have a menu only consisting of application actions or
rilian added a comment.
Thanks so much)
1. Unity is dead, but I forked unity-gtk-module, patched it for all distros,
fixed some bugs and called appmenu-gtk-module. So, Unity is dead, but unity
action prefixes is live.
2. To use unity-gtk-module or appmenu-gtk-module you need to
broulik added a comment.
Hi Konstantin,
thank you very much for your input!
> One can be missing, and then incomplete menu should render:
In Plasma we don't typically use this separate "app menu" (although I'd like
to do that but as a separate menu), so what I do is I show the
rilian added a comment.
Hello, I am Konstantin, developer of vala-panel-appmenu. I have some comments
about your application.
MenuModel protocol consitsts for 5 items:
AppMenu - with property _GTK_APPMENU_OBJECT_PATH
MenuBar - with property _GTK_MENUBAR_OBJECT_PATH
It is a
broulik updated this revision to Diff 27077.
broulik retitled this revision from "WIP: GMenu-DBusMenu-Proxy" to
"GMenu-DBusMenu-Proxy".
broulik edited the summary of this revision.
broulik added a comment.
- Cleanup code and use categorized logging
- Monitor action changes (e.g. toggled
20 matches
Mail list logo
