D10483: Polish ToolBarApplicationHeader appearance

This revision was automatically updated to reflect the committed changes. Closed by commit R169:667cc4318a18: Polish ToolBarApplicationHeader appearance (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10483?vs=27096&id=27097 REVISION DE

D10483: Polish ToolBarApplicationHeader appearance

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH header-polish REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: abetts, #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10483: Polish ToolBarApplicationHeader appearance

ngraham added a comment. I've reverted the title alignment changes for now. There are too many patches in flight to keep up! If this is good, let's land it (and also Aleix's patches once they're all good too) and then I'll iterate on the titles a bit more. Does that sound like a plan? REPOS

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: abetts, #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10483: Polish ToolBarApplicationHeader appearance

ngraham updated this revision to Diff 27096. ngraham added a comment. Revert change to center title REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10483?vs=27071&id=27096 BRANCH header-polish REVISION DETAIL https://phabricator.kde.org/D10483 AFFECT

D10483: Polish ToolBarApplicationHeader appearance

mart added a comment. In D10483#205563 , @abetts wrote: > Sorry guys, this proposed left alignment just won't work IMHO. The reason is that we are turning the bar into a CSD. Unlike a desktop application, we don't have the ability to shrink the

D10483: Polish ToolBarApplicationHeader appearance

abetts added a comment. Sorry guys, this proposed left alignment just won't work IMHO. The reason is that we are turning the bar into a CSD. Unlike a desktop application, we don't have the ability to shrink the application in mobile. What this amounts to is that people will want to add more

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the test plan for this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10483: Polish ToolBarApplicationHeader appearance

ngraham created this revision. ngraham added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Increase the toolbar height by 4 pixels, to make it loo