apol added a comment.
+1 makes sense to me.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D10502
To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein
ngraham edited the summary of this revision.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D10502
To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein
ngraham marked an inline comment as done.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D10502
To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein
ngraham updated this revision to Diff 27150.
ngraham added a comment.
Use a more programmatically correct approach (top_adding+buttomPadding
instead of Units.gridUnit*2); this will work for clients that change the
padding values
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
apol added inline comments.
INLINE COMMENTS
> OverlaySheet.qml:270
> width: root.contentItem.implicitWidth <= 0 ? mainItem.width :
> Math.max(mainItem.width/2, Math.min(mainItem.width,
> root.contentItem.implicitWidth))
> -height: scrollView.flickableItem &&
>
ngraham edited the test plan for this revision.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D10502
To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein
ngraham created this revision.
ngraham added reviewers: Kirigami, apol.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The OverlaySheet already defines a bottomMargin, so we
