D10660: [Weather applet] Let Return invoke search

kossebau added a comment. I would like to consider discarding this patch and the related introduction of the "acceptOnReturnPressed" property to Plasma config page concept only needed for this so far. I am currently drafting to rework the UI of the weather station page in the dialog,

D10660: [Weather applet] Let Return invoke search

kossebau added inline comments. INLINE COMMENTS > ConfigWeatherStation.qml:33 > + > +property bool acceptOnReturnPressed: !searchStringEdit.activeFocus || > searchStringEdit.length === 0 > could be "readonly property" as well, no? REPOSITORY R114 Plasma Addons REVISION DETAIL

D10660: [Weather applet] Let Return invoke search

mart added a comment. yeah, for me that other patch is ok, is not optimal but should all be documented in line in that file maaaybe introducing a root component for those config uis.. not sure REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To:

D10660: [Weather applet] Let Return invoke search

kossebau added a comment. In D10660#232255 , @mart wrote: > any news on this? Blocked a little by me having the desire to have the secret API used here made public documented, cmp. question to you in

D10660: [Weather applet] Let Return invoke search

mart added a comment. any news on this? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10660: [Weather applet] Let Return invoke search

broulik edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

kossebau added a comment. Not tested, but seems good to me by pure reading. INLINE COMMENTS > ConfigWeatherStation.qml:33 > + > +property bool acceptOnReturnPressed: !searchStringEdit.activeFocus || > searchStringEdit.length === 0 > Slightly undecided: given above we use the `length`

D10660: [Weather applet] Let Return invoke search

broulik edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

broulik edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

broulik created this revision. broulik added reviewers: Plasma, kossebau. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Depends on D10659