D10692: parent full representation to the proper window at start

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b17fa4bea6f4: parent full representation to the proper window at start (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27840&id

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27840. mart added a comment. - remove useless z reassignment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27767&id=27840 BRANCH arcpatch-D10692 REVISION DETAIL https://phabricator.kde.org/D10692

D10692: parent full representation to the proper window at start

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D10692 REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma, broulik Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai

D10692: parent full representation to the proper window at start

mart added inline comments. INLINE COMMENTS > broulik wrote in main.qml:121 > Shouldn't this be a binding? not really, as is just an inizialization to have the size it will have when properly reparented when the popup is open, it's put in the StackView, so is them propely anchored and all pu

D10692: parent full representation to the proper window at start

broulik added inline comments. INLINE COMMENTS > main.qml:121 > +if (applet.fullRepresentationItem) { > +applet.fullRepresentationItem.width = > expandedRepresentation.width > +applet.fullRepresentationItem.width = > expandedRepresentation.height Shouldn't this

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27767. mart added a comment. remove leftovers REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27715&id=27767 BRANCH arcpatch-D10692 REVISION DETAIL https://phabricator.kde.org/D10692 AFFECTED FILES

D10692: parent full representation to the proper window at start

mart added inline comments. INLINE COMMENTS > apol wrote in systemtray.h:30 > Why? eww, leftover REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10692: parent full representation to the proper window at start

apol added inline comments. INLINE COMMENTS > systemtray.h:30 > class QQuickItem; > +class QQuickWindow; > class PlasmoidModel; Why? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: apol, broulik, hein, davidedmundson, plasma-deve

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27715. mart added a comment. - new approach: parent full reps to the dialog only when needed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27710&id=27715 BRANCH arcpatch-D10692 REVISION DETAIL http

D10692: parent full representation to the proper window at start

mart added a comment. now it depends from D10722 , which can preload it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: broulik, hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mo

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27710. mart added a comment. - less hacks on this part, ones in libplasma enough REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27633&id=27710 BRANCH arcpatch-D10692 REVISION DETAIL https://phabrica

D10692: parent full representation to the proper window at start

mart added inline comments. INLINE COMMENTS > broulik wrote in Menu.qml:36 > Would that also help Kickoff's initial opening? > > Also see D10557 which makes a huge > difference without that.. yeah, pretty much everything that has a listview in it, tough i d

D10692: parent full representation to the proper window at start

broulik added inline comments. INLINE COMMENTS > Menu.qml:36 > +//which makes quite a visual difference when this plasmoid gets > preloaded (ensures it actually gets preloaded fully) > +Component.onCompleted: menuListView.forceLayout() > ListView { Would that also help Kickoff's in

D10692: parent full representation to the proper window at start

hein added a comment. It does use it btw, just not for subdialogs. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma Cc: hein, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10692: parent full representation to the proper window at start

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ExpandedRepresentation.qml:29 > How does this avoid a useless Dialog resize? otherwise mainItem starts being sized 0x0, then on Dialog showevent, it searches for its Layout property and resizes it based on that, this makes th

D10692: parent full representation to the proper window at start

davidedmundson added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:29 > > +//set width/height to avoid an useless Dialog resize > +width: Layout.minimumWidth How does this avoid a useless Dialog resize? > systemtray.cpp:346 > > +void SystemTray::createPopup(QQuickWin

D10692: parent full representation to the proper window at start

mart updated this revision to Diff 27633. mart added a comment. - forces delegates creation in the item view REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27627&id=27633 BRANCH phab/preloadsystray REVISION DETAIL https://phabricator

D10692: parent full representation to the proper window at start

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY this avoids some unwanted scene changes and speeds up the first open a bi