D11059: Add convenience method to get a persistent model index from TasksModel

2018-03-05 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Used in the minimizeAll plasmoid (see D10019

D11059: Add convenience method to get a persistent model index from TasksModel

2018-03-05 Thread Chris Holland
Zren added a comment. Typo. You only have 1 "s" in persistent there. makePeristentModelndex QPersistentModelIndex clients.push(tasksModel.makePersistentModelIndex(i)); // minimizeall REPOSITORY R120 Plasma Workspace REVISION

D11059: Add convenience method to get a persistent model index from TasksModel

2018-03-05 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > tasksmodel.h:823 > + */ > +Q_INVOKABLE QPersistentModelIndex makePeristentModelndex(int row, int > childRow = -1) const; > + Per*s*istent REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11059 To: david

D11059: Add convenience method to get a persistent model index from TasksModel

2018-03-06 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D11059 To: davidedmundson, #plasma, hein Cc: broulik, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterb

D11059: Add convenience method to get a persistent model index from TasksModel

2018-03-07 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:290ee95dacdf: Add convenience method to get a persistent model index from TasksModel (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11059?vs=28720&id=28947#toc RE