D11063: [mediacontroller applet] Reorder elements

romangg updated this revision to Diff 28892. romangg added a comment. - Minor changes proposed by Kai REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28889=28892 BRANCH mediaAppletStructure REVISION DETAIL

D11063: [mediacontroller applet] Reorder elements

broulik accepted this revision. broulik added a comment. Go go go :) INLINE COMMENTS > ExpandedRepresentation.qml:174 > > -ColumnLayout { > -Layout.fillWidth: true > -spacing: units.smallSpacing / 2 > - > -PlasmaExtras.Heading { >

D11063: [mediacontroller applet] Reorder elements

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d511a766779b: [mediacontroller applet] Reorder elements (authored by romangg). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28892=28895

D11063: [mediacontroller applet] Reorder elements

romangg updated this revision to Diff 28889. romangg added a comment. Rebased on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28816=28889 BRANCH mediaAppletStructure REVISION DETAIL https://phabricator.kde.org/D11063

D11063: [mediacontroller applet] Reorder elements

ngraham added a comment. In D11063#220051 , @abetts wrote: > Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe. > > Media

D11063: [mediacontroller applet] Reorder elements

abetts added a comment. Not sure if it is within the scope of this patch but the spacing is uneven vertically between elements in the notification window. They need more space to breathe. Media Player Cover Artwork Progress Bar | | Song Title | | Media

D11063: [mediacontroller applet] Reorder elements

romangg added inline comments. INLINE COMMENTS > broulik wrote in ExpandedRepresentation.qml:124 > Why is this thing no longer in a `ColumLayout`? I want to have the controls always at the same fixed position at the bottom of the applet. With a layout it would shift them around according to

D11063: [mediacontroller applet] Reorder elements

romangg updated this revision to Diff 28816. romangg marked 7 inline comments as done. romangg added a comment. - Comments by Kai REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28772=28816 BRANCH mediaAppletStructure REVISION DETAIL

D11063: [mediacontroller applet] Reorder elements

andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStructure REVISION DETAIL https://phabricator.kde.org/D11063 To: romangg, #plasma, andreask Cc: nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai,

D11063: [mediacontroller applet] Reorder elements

romangg updated this revision to Diff 28772. romangg added a comment. - [mediacontroller applet] App icon when cover not available REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11063?vs=28730=28772 BRANCH mediaAppletStructure REVISION DETAIL

D11063: [mediacontroller applet] Reorder elements

broulik added a comment. Cool! INLINE COMMENTS > ExpandedRepresentation.qml:123 > +id: playerCombo > +width: 0.6 * parent.width > +height: visible ? undefined : 0 `Math.round` > ExpandedRepresentation.qml:124 > +width: 0.6 * parent.width > +height:

D11063: [mediacontroller applet] Reorder elements

romangg added a dependent revision: D11056: [mediacontroller applet] Use media playback status icons. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11063 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11063: [mediacontroller applet] Reorder elements

romangg added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:269 > +width: parent.width > +spacing: -units.smallSpacing > + Pls tell me a way to use Headings without huge margins all around. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D11063: [mediacontroller applet] Reorder elements

romangg edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11063 To: romangg, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

romangg created this revision. romangg added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Improve overall look according to bug report and mockup.