D11220: option to force FolderView icon-only presentation

2018-03-25 Thread Michail Vourlakos
mvourlakos abandoned this revision. mvourlakos added a comment. can be closed because https://phabricator.kde.org/D11651 was accepted... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11220 To: mvourlakos, #plasma, mart, hein Cc: sebas, broulik, hein,

D11220: option to force FolderView icon-only presentation

2018-03-24 Thread Michail Vourlakos
mvourlakos added a comment. In D11220#232803 , @hein wrote: > If it's the only way to end this debate, could you instead implement the patch that uses the icon size setting as switch threshold? I created the following:

D11220: option to force FolderView icon-only presentation

2018-03-24 Thread Eike Hein
hein added a comment. I really think this is ugly and don't want it :/ If it's the only way to end this debate, could you instead implement the patch that uses the icon size setting as switch threshold? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11220: option to force FolderView icon-only presentation

2018-03-23 Thread Marco Martin
mart added a comment. i don't see much use case for it, but... Eike, i think the final word would be up to you, what do you think about it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11220 To: mvourlakos, #plasma, mart, hein Cc: sebas, broulik, hein,

D11220: option to force FolderView icon-only presentation

2018-03-17 Thread Michail Vourlakos
mvourlakos added a comment. In D11220#223836 , @hein wrote: > Hmm I don't like the approach about putting this into individual applets - I think the containment should force constraints on the applets instead, and the applets need to

D11220: option to force FolderView icon-only presentation

2018-03-13 Thread Michail Vourlakos
mvourlakos added a comment. settings window looks like: F5752898: εικόνα.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11220 To: mvourlakos, #plasma, mart Cc: sebas, broulik, hein, plasma-devel, ZrenBot,

D11220: option to force FolderView icon-only presentation

2018-03-13 Thread Michail Vourlakos
mvourlakos updated this revision to Diff 29439. mvourlakos added a comment. - update semantics based on feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11220?vs=29195=29439 BRANCH alwaysShowAsIcon REVISION DETAIL

D11220: option to force FolderView icon-only presentation

2018-03-13 Thread Michail Vourlakos
mvourlakos added a comment. In D11220#224622 , @mart wrote: > Shouldn't the quick launch applet cover this use case? The quick launch applet can show folder contents or activities-pinned documents? REPOSITORY R119 Plasma Desktop

D11220: option to force FolderView icon-only presentation

2018-03-13 Thread Marco Martin
mart added a comment. Shouldn't the quick launch applet cover this use case? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11220 To: mvourlakos, #plasma, mart Cc: sebas, broulik, hein, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11220: option to force FolderView icon-only presentation

2018-03-12 Thread Michail Vourlakos
mvourlakos added a comment. Please read also: https://bugs.kde.org/show_bug.cgi?id=379888 why I proposed this. The issue appeared from Latte Dock. When the user uses the parabolic effect and the FolderView is animated then somewhere in the middle of the animation it changes from icon

D11220: option to force FolderView icon-only presentation

2018-03-12 Thread Sebastian Kügler
sebas added a comment. In principle yes, but the applet should of course react suitably to these constraints. A config option for this seems to duplicate the concept of constraints (which are indeed determined by the containment.) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11220: option to force FolderView icon-only presentation

2018-03-12 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ConfigIcons.qml:155 > +checked: cfg_forceIconInPanel > +text: i18n("Force icon presentation in panel") > +} "Always show as icon" or something like that? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D11220: option to force FolderView icon-only presentation

2018-03-12 Thread Eike Hein
hein added a reviewer: mart. hein added a comment. Hmm I don't like the approach about putting this into individual applets - I think the containment should force constraints on the applets instead, and the applets need to follow the constraints. That's more Plasma-idiomatic to me. Marco?

D11220: option to force FolderView icon-only presentation

2018-03-10 Thread Michail Vourlakos
mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --when a FolderView applet is located in panel, there