D11516: use plasma_install_bundled_package

kossebau added inline comments. INLINE COMMENTS > mart wrote in main.qml:24 > ah, to me it appeared to break fifteenpuzzle, can you test if also for you > using the qrc way, but keeping this unaltered, breaks it? Sadly cannot test currently, self-compiled plasma-frameworks in custom prefix

D11516: use plasma_install_bundled_package

This revision was automatically updated to reflect the committed changes. Closed by commit R114:c505a726b3f1: use plasma_install_bundled_package (authored by mart). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11516?vs=30297=30324 REVISION DETAIL

D11516: use plasma_install_bundled_package

mart added a comment. In D11516#232097 , @kossebau wrote: > Cannot test at the moment, but looks straight forward, so no objection from me. > > Besides the unrelated changes, they want to have their own commits :) INLINE COMMENTS >

D11516: use plasma_install_bundled_package

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Cannot test at the moment, but looks straight forward, so no objection from me. Besides the unrelated changes, they want to have their own commits :) INLINE COMMENTS >

D11516: use plasma_install_bundled_package

mart updated this revision to Diff 30297. mart added a comment. - bump frameworks dep for new install bundled package REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11516?vs=30012=30297 BRANCH phab/bundle REVISION DETAIL

D11516: use plasma_install_bundled_package

mart added a comment. In D11516#230172 , @kossebau wrote: > How new is the plasma_install_bundled_package macro? Needs a bump of min kf5 version as well, so people know which plasma-framework version they need at least? good point, the

D11516: use plasma_install_bundled_package

kossebau added a comment. How new is the plasma_install_bundled_package macro? Needs a bump of min kf5 version as well, so people know which plasma-framework version they need at least? Otherwise patch fine with me, not aware of details, so assume you have your reason for going rcc :)

D11516: use plasma_install_bundled_package

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY use the new install macro to install bundled packages in the form of an