D11613: call beginRemoveRows before removing the data

2018-03-26 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R115:722ee38399a1: call beginRemoveRows before removing the data (authored by davidedmundson). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D11613: call beginRemoveRows before removing the data

2018-03-26 Thread David Rosca
drosca added a comment. Into Plasma/5.12 please. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D11613 To: davidedmundson, #plasma, drosca Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11613: call beginRemoveRows before removing the data

2018-03-23 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's perfectly valid to call ::data() from