This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:743e2bc94391: If GL context creation fails fall back to
the software renderer (authored by davidedmundson).
CHANGED PR
mart added a comment.
anyways, +1 rom me.. tough it would probably be needed some ui somewhere for
trying to reenable opengl, maybe visible at all only when disabled.
the desktop config dialog may be quite random, tough i don't know where else
it could be
REPOSITORY
R120 Plasma Workspace
davidedmundson added a comment.
Kwin's crash detection is this pernament
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D11722
To: davidedmundson, #plasma
Cc: mart, broulik, graesslin, plasma-devel, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreut
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in main.cpp:186
> Nvidia driver upgrade is how I ended up in my situation :D
>
> Pernament global forcing is what I've gone for. Which is why it sort of
> already covers the lock screen case.
> I could make it not save and do it
graesslin added a comment.
An env variable would not work for things like lock screen as the process
starting the lock screen is started before Plasmashell.
Given that I think persistent storage makes more sense. But a way to get back
would be cool. Maybe we could create a test app to se
davidedmundson updated this revision to Diff 30771.
davidedmundson added a comment.
Remove debug
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11722?vs=30643&id=30771
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D11722
AFFECTED
davidedmundson added inline comments.
INLINE COMMENTS
> broulik wrote in main.cpp:186
> So you will permanently force software rendering even for a single hickup
> (think of upgrading nvidia driver)?
Nvidia driver upgrade is how I ended up in my situation :D
Pernament global forcing is what I'
broulik added a comment.
I like the direction but I would like
- something that doesn't permanently lock out the user if something failed
once, we either need a KCM like KWin has or a SNI ("we had to switch you back
to software rendering" with a sad puppy face)
- something more generic
graesslin added a comment.
I like this change
INLINE COMMENTS
> desktopview.cpp:63
> [this, corona]() {
> +qDebug() << QQuickWindow::sceneGraphBackend();
> // check whether the GL Context supports OpenGL
This looks like too much debug or like a n
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
If we cannot create a GL context, instead of
10 matches
Mail list logo
