D12277: Fix build with Qt 4

2018-04-17 Thread Jonathan Riddell
jriddell added a comment. This is to stop the build failure we get on Neon https://build.neon.kde.org/job/xenial_unstable_kde_breeze_bin_amd64/209/console REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12277 To: fvogt, #breeze, davidedmundson Cc: jriddell, zzag, p

D12277: Fix build with Qt 4

2018-04-17 Thread Vlad Zagorodniy
zzag added a comment. OK, nvmd. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12277 To: fvogt, #breeze, davidedmundson Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12277: Fix build with Qt 4

2018-04-17 Thread Vlad Zagorodniy
zzag added a comment. Oh, God, I forgot to check Q_CC_CLANG in Qt 4. Also, that's weird Q_CC_GNU has no value in Qt 4.. http://doc.qt.io/archives/qt-4.8/qtglobal.html#Q_CC_GNU REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12277 To: fvogt, #breeze, davidedmundso

D12277: Fix build with Qt 4

2018-04-17 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R31:f4f7b599aff5: Fix build with Qt 4 (authored by fvogt). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12277?vs=32373&id=32374 REVISION DETAIL https://phabricator.kde

D12277: Fix build with Qt 4

2018-04-17 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Breeze. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY In Qt 4, the compiler detection macros have no value, so they can't be compared against. So just use the compiler-specific one