D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey created this revision. sharvey added reviewers: davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Aligned detail item labels; added "Not Applicable"

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey added a comment. **Before** F5819725: polkit-details-before.png **After** F5819727: polkit-details-after.png REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabri

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey added a comment. A little UI polishing, just for the details panel. The redesign of the main dialog is still under discussion (T8569 , D12311 ) so I touched up the details. Does anyone know of an application t

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

abetts added a comment. +1 REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham Cc: abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey updated this revision to Diff 32938. sharvey added a comment. - Turned off "glow" effect on vendor URL; was rendering strange transparency REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12479?vs=32917&id=32938 BRANCH polish-d

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

ngraham accepted this revision. ngraham added a comment. LTGM! REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH polish-detail-panel (branched from master) REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham, #plasma Cc: abetts, plasma-devel, #pla

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

ngraham added a comment. Since you're doing a lot of work in this repo, perhaps your next patch should be to ad an `.arccconfig` file! :) REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH polish-detail-panel (branched from master) REVISION DETAIL https://phabricator.kde.org/D12479

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

This revision was automatically updated to reflect the committed changes. Closed by commit R121:b340539eca13: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces (authored by sharvey, committed by ngraham). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE L

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey added a subscriber: bruns. sharvey added a comment. In D12479#252978 , @ngraham wrote: > Since you're doing a lot of work in this repo, perhaps your next patch should be to ad an `.arccconfig` file! :) Hm, can your commit be undon

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

ngraham added a comment. Just open a new revision, it's easier. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham, #plasma Cc: bruns, abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, al

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

bruns added a comment. New revision with remaining tasks: D12498 REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham, #plasma Cc: bruns, abetts, plasma-devel, #plasma, ra