D12515: QML applets need to manage padding by themselves

2018-04-26 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R124:6a9df821ecfa: QML applets need to manage padding by themselves (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12515?vs=33110=33142

D12515: QML applets need to manage padding by themselves

2018-04-26 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Same as before, we're just refactoring to clean some code :) REPOSITORY R124 System Settings BRANCH phab/externalpadding REVISION DETAIL https://phabricator.kde.org/D12515 To: mart,

D12515: QML applets need to manage padding by themselves

2018-04-25 Thread Andres Betts
abetts added a comment. What does this look like now? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D12515 To: mart, #plasma Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12515: QML applets need to manage padding by themselves

2018-04-25 Thread Marco Martin
mart updated this revision to Diff 33110. mart added a comment. - use pixelmetrics from the style for the padding REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12515?vs=33061=33110 BRANCH phab/externalpadding REVISION DETAIL

D12515: QML applets need to manage padding by themselves

2018-04-25 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY remove our padding from qml kcms this fixes the cutted away shadow for