D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Marco Martin
mart added a comment. In D12563#257052 , @dscheffer wrote: > In D12563#257024 , @broulik wrote: > > > Urgh. Just because you can doesn't mean you should. This will horribly break if the user is run

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Dennis Scheffer
dscheffer added a comment. In D12563#257024 , @broulik wrote: > Urgh. Just because you can doesn't mean you should. This will horribly break if the user is running a different look and feel package (different form factor, distro branding, etc).

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Kai Uwe Broulik
broulik added a comment. > wrote a C++ plugin that loads the RunCommand.qml using KPackage and subsequently registers the file with the qml type system. Urgh. Just because you can doesn't mean you should. This will horribly break if the user is running a different look and feel package (

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Dennis Scheffer
dscheffer added a comment. In D12563#257018 , @mart wrote: > what's the exact use case? what plasmoid are you writing? (btw, you can't use that qml file in a plasmoid, if you want to embed parts of krunner in a plasmoids, those are components co

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-05-02 Thread Marco Martin
mart added a comment. what's the exact use case? what plasmoid are you writing? (btw, you can't use that qml file in a plasmoid, if you want to embed parts of krunner in a plasmoids, those are components coming from milou) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabric

D12563: [Run Command] Add closable property so that close button can be disabled.

2018-04-27 Thread Dennis Scheffer
dscheffer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dscheffer requested review of this revision. REVISION SUMMARY When using RunCommand.qml, e.g. as part of a plasmoid, it does not always make sense to have a