D12851: Change preview text background color to match with default combobox background color

2019-12-05 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, this doesn't look so great all on its own: F7801317: Screenshot_20191205_143423.png I think the graphical representations

D12851: Change preview text background color to match with default combobox background color

2019-01-01 Thread Nathaniel Graham
ngraham added a comment. I vote for landing this now. It's independent of other changes and improves the legibility. #plasma folks? REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_comboboxes (branched from master) REVISION DETAIL

D12851: Change preview text background color to match with default combobox background color

2018-06-07 Thread Henrik Fehlauer
rkflx added a comment. In D12851#275112 , @progwolff wrote: > Sorry for the delay... No problem ;) > If you want to have this on the 5.13 branch, please feel free to land it. I guess that's something for #Plasma

D12851: Change preview text background color to match with default combobox background color

2018-06-07 Thread Julian Wolff
progwolff added a comment. Sorry for the delay... I planned to land this together with D12849 and D12925 . It will take me two weeks or so until I can continue working on this. I need to finish my master thesis

D12851: Change preview text background color to match with default combobox background color

2018-06-06 Thread Henrik Fehlauer
rkflx added a comment. Anything left to be done here? I guess this should land on the `Plasma/5.13` branch, since it's still broken there (I almost wrote a patch…). Patch LGTM, but there's still an issue (but not sure if intentional or not): The hover effect does not apply to the

D12851: Change preview text background color to match with default combobox background color

2018-05-13 Thread Julian Wolff
progwolff created this revision. progwolff added reviewers: mart, abetts, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY The default combobox background color is