D12855: Move search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34129. sharvey added a comment. - Remove hardcoded pixel sizes; misc code cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34083=34129 BRANCH new-search-row (branched from master) REVISION

D12855: Move search field to its own row so it doesn't get compressed

sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:157 > ? Not sure The extra comment adds anything. Instead we should just remove the > commented-out code in a new patch IMHO. I'm always unclear what to do when I find blocks of other people's comments. Some

D12855: Move search field to its own row so it doesn't get compressed

ngraham added inline comments. INLINE COMMENTS > WidgetExplorer.qml:157 > /* > +* This was here when I got here 5/12/18 - sharvey > PlasmaCore.Dialog { ? Not sure The extra comment adds anything. Instead we should just remove the commented-out code in a new patch IMHO. >

D12855: Move search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34083. sharvey added a comment. Submitted from wrong local branch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34078=34083 BRANCH new-search-row (branched from master) REVISION DETAIL

D12855: Move search field to its own row so it doesn't get compressed

sharvey added a comment. Before: {F5846708} -- After: F5846710: Screenshot_20180513_082104.png F5846712: Screenshot_20180513_082036.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12855: Move search field to its own row so it doesn't get compressed

sharvey created this revision. sharvey added reviewers: ngraham, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Move search to its own row to prevent it from