D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. > The purpose of this patch was to simply hide the standalone launcher functionality a little Isn't it more than "a little" though? What other way to add apps to the panel now remains other than DND, which many people never attempt? > Hmm, I don't see them in g

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added a comment. In D12969#266528 , @hein wrote: > Widget-based launchers do have jump lists, fwiw Hmm, I don't see them in git master or in any other version of Plasma that I've ever used. F5864058: No jump list.png

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. Widget-based launchers do have jump lists, fwiw REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12969 To: ngraham, #plasma, mart Cc: sharvey, Fuchs, hein, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moham

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added a comment. The idea was that nobody who uses a task manager would actually want to create launchers instead of pinning their apps to it. Perhaps that was not totally true, but with Christian's patch, I think it can become even more true, because the patch addresses the case whe

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

Fuchs added a comment. In D12969#266503 , @hein wrote: > > In that case I would honestly argument for dropping Task Manager pinning entirely: I've never entirely liked that it complicates the Task Manager toward doing multiple thin

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. > And personally I consider pinning to be activity dependant way more complicated than having both options to pin and have a launcher I'm also very unhappy with this hyper-complicated context menu. It made it in because everyone was getting impatient on this feature

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

sharvey added a comment. As a side note, usage of the terms "kicker" and/or "kickoff" aren't user-friendly at all. They're basically internal names and aren't mentioned in any user-facing text. I'm not trying to hijack the issue; this is just one of those barriers to entry we should try to k

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added a comment. Christian's patch allows pinned Task Manager icons to be always visible, yeah. However, if we merge that but reject this, IMHO the situation becomes even more confusing for the average user. I think we really need to focus on the "Simple by default" side of the equat

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

Fuchs added a comment. Maybe we need to discuss things, especially also with https://phabricator.kde.org/D12463 where I have an interest in, on a broader scale. I agree that both need to exist and have different use cases, personally I think I'd only show the task manager pin in the con

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. > That's disappointing to hear and a bit frustrating considering that it never came up in the Bugzilla ticket I filed months 3 ago I've never seen that ticket because it was filed against the wrong component and I wasn't CC'd on it. Making sure the relevant maintain

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added a comment. That's disappointing to hear and a bit frustrating considering that it never came up in the Bugzilla ticket I filed months 3 ago, and the patch was approved by one Plasma developer and not objected to by another. Can I try to explain my reasoning before we revert it?

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

hein added a comment. I veto this patch, sorry. These are different features and they're both intended to be there. Task Manager pinning is not a replacement for permanent launchers. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12969 To: ngraham, #plasma,

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12969 To: ngraham, #plasma, mart Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. now became 5.14 for sure, but i think it's safe to go REPOSITORY R119 Plasma Desktop BRANCH no-add-to-panel-as-widget-when-theres-a-task-manager (branched from Plasma/5.13) REVISION DETAI

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

davidedmundson resigned from this revision. davidedmundson added inline comments. INLINE COMMENTS > ngraham wrote in actionlist.cpp:156 > This patch worked just for me all by itself, so I wasn't aware this required > a plasma-framework change (I just moved the conditional around a bit, > basica

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in actionlist.cpp:156 > I assume you have a second patch in p-f for this? > > (which means this is Plasma 5.14 material) This patch worked just for me all by itself, so I wasn't aware this required a plasma-framework change

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

davidedmundson added inline comments. INLINE COMMENTS > actionlist.cpp:156 > actionList << Kicker::createActionItem(i18n("Pin to Task Manager"), > "addToTaskManager"); > +} else if (ContainmentInterface::mayAddLauncher(appletInterface, > ContainmentInterface::Panel)) { > +a

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

ngraham created this revision. ngraham added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Users get confused by the difference between "Pin to Task Manager"