D13148: Allow Kirigami build without KWin tablet mode dependency

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:f5cd75acadf4: Allow Kirigami build without KWin tablet mode dependency (authored by murillobernardes, committed by

D13148: Allow Kirigami build without KWin tablet mode dependency

apol added a comment. In D13148#271691 , @murillobernardes wrote: > Sorry, first time contributing to kde-related project. > > I’m not sure what I need to do next? Send a pull request somewhere? No, you just would land the patch. I'm

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes added a comment. Sorry, first time contributing to kde-related project. I’m not sure what I need to do next? Send a pull request somewhere? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13148 To: murillobernardes, mart, davidedmundson Cc:

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. ping? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13148 To: murillobernardes, mart, davidedmundson Cc: davidedmundson, plasma-devel, apol, mart, hein

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes updated this revision to Diff 35133. murillobernardes added a comment. Update based on your comments. The MacOS elif is the same as the else, so I removed. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13148?vs=35049=35133 REVISION

D13148: Allow Kirigami build without KWin tablet mode dependency

davidedmundson added a comment. If we have an defined(KIRIGAMI_USE_DBUS) we don't need to put if (!APPLE && ..) in the code which would be much much cleaner. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13148 To: murillobernardes, mart, davidedmundson Cc:

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. almost there :) since there is also a qmake mode to build for embedded, where dbus should be disabled as well, I would prefer to flip the logic. so, have a KIRIGAMI_ENABLE_DBUS which is undefined by default (so nothing to do in the .pri file) but having it defined

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes updated this revision to Diff 35049. murillobernardes added a comment. Add option to disable dbus dependency (build time). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13148?vs=34970=35049 REVISION DETAIL

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes added a comment. In D13148#269556 , @mart wrote: > In D13148#269233 , @murillobernardes wrote: > > > I did not patch CMakeLists.txt because I can't test it. I could not get a

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. In D13148#269233 , @murillobernardes wrote: > I did not patch CMakeLists.txt because I can't test it. I could not get a system with all the right versions of all build dependencies to build Kirigami. > > On

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes added a comment. In D13148#269205 , @davidedmundson wrote: > This doesn't achieve anything useful. It does for projects that have their own build system. > You're not changing any dependencies as you still link

D13148: Allow Kirigami build without KWin tablet mode dependency

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This doesn't achieve anything useful. You're not changing any dependencies as you still link against DBus as CMake is unchanged in this patch. Code

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes created this revision. murillobernardes added a reviewer: mart. murillobernardes added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. murillobernardes requested review of this revision. REVISION SUMMARY Even on linux it might be the case to not