D13243: Add checkbox that can show virtual streams in the applet.

2019-10-12 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. Ping! REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D13243 REVISION DETAIL https://phabricator.kde.org/D13243 To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-27 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sane enough to me. Even though it's a new esoteric option, it does seem useful for certain use cases and it's buried in a config window that almost nobody will ever see, so I think

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-27 Thread Sefa Eyeoglu
sefaeyeoglu updated this revision to Diff 66952. sefaeyeoglu added a comment. Change behaviour of configuration. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66951=66952 BRANCH arcpatch-D13243 REVISION DETAIL

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-27 Thread Sefa Eyeoglu
sefaeyeoglu updated this revision to Diff 66951. sefaeyeoglu added a comment. Put checkbox into own category REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66926=66951 BRANCH arcpatch-D13243 REVISION DETAIL

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-27 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConfigGeneral.qml:89 > + > +QQC2.CheckBox { > +id: showRealDevicesOnly This isn't a feedback-related item so it shouldn't be in the Feedback

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-26 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. In D13243#538519 , @davidedmundson wrote: > What's the use case? I have a "module-null-sink" loaded at all times. I use it to record from via OBS, so I can selectively record Desktop Audio. (This is coupled

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-26 Thread David Edmundson
davidedmundson added a comment. What's the use case? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13243 To: sefaeyeoglu, #plasma, drosca, #vdg Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-26 Thread Sefa Eyeoglu
sefaeyeoglu updated this revision to Diff 66926. sefaeyeoglu added a comment. Add copyright header REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66925=66926 BRANCH arcpatch-D13243 REVISION DETAIL

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-26 Thread Sefa Eyeoglu
sefaeyeoglu updated this revision to Diff 66925. sefaeyeoglu added a comment. Rebase onto master REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=35273=66925 BRANCH arcpatch-D13243 REVISION DETAIL

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-26 Thread Sefa Eyeoglu
sefaeyeoglu added a comment. In D13243#538434 , @ngraham wrote: > Yikes, looks like this never went anywhere. :/ > > Can you rebase it? I actually don't remember ever making this but of course I can :D REPOSITORY R115 Plasma Audio

D13243: Add checkbox that can show virtual streams in the applet.

2019-09-26 Thread Nathaniel Graham
ngraham added reviewers: Plasma, drosca, VDG. ngraham added a comment. Yikes, looks like this never went anywhere. :/ Can you rebase it? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13243 To: sefaeyeoglu, #plasma, drosca, #vdg Cc: ngraham,

D13243: Add checkbox that can show virtual streams in the applet.

2018-05-31 Thread Sefa Eyeoglu
sefaeyeoglu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sefaeyeoglu requested review of this revision. REVISION SUMMARY Adds a checkbox and changes the filter of the ListView models. REPOSITORY R115 Plasma