D13346: Use more contextual strings for some button labels

2018-06-05 Thread Andres Betts
abetts added a comment. In D13346#274450 , @emateli wrote: > > In D13346#274446 , @abetts wrote: > > Could we have a button that enables/disables bluetooth instead? We can show the warning message

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Emirald Mateli
emateli added a comment. > In D13346#274446 , @abetts wrote: > Could we have a button that enables/disables bluetooth instead? We can show the warning message only if it doesn't seem to be working? or for example, if it runs into an error when

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Andres Betts
abetts added a comment. In D13346#274427 , @ngraham wrote: > Red is for errors, orange is for warnings, and blue is for information. The red is not as harsh as it used to be, but do you think orange would be a more appropriate color? I

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Nathaniel Graham
ngraham added a comment. Red is for errors, orange is for warnings, and blue is for information. The red is not as harsh as it used to be, but do you think orange would be a more appropriate color? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D13346 To:

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Every Bluetooth error's "fix this error" button's text is

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Andres Betts
abetts added a comment. +1 I feel this is a must. We are trying to convey that the user needs to enable Bluetooth in order to make it work. There is real issue there. In fact, could we maybe change the color message from RED to something more informational? REPOSITORY R97 Bluedevil

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R97:c7f72367599b: Use more contextual strings for some button labels (authored by ngraham). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13346?vs=35583=35607

D13346: Use more contextual strings for some button labels

2018-06-05 Thread Kai Uwe Broulik
broulik added a comment. +1 REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D13346 To: ngraham, #plasma, #vdg Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart