This revision was automatically updated to reflect the committed changes.
Closed by commit R134:1e31a6e8d524: Improve the clarity and presentation of the
update details text field (authored by ngraham).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde
ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patche makes it a bit more obvious what
ngraham added a comment.
Before landing this, I'd still prefer a quick test from anyone not using an
Ubuntu-based distro to make sure that the strings still make sense. Thanks!
REPOSITORY
R134 Discover Software Store
BRANCH
clearer-update-text (branched from master)
REVISION DETAIL
ht
ngraham updated this revision to Diff 35804.
ngraham marked an inline comment as done.
ngraham added a comment.
Use an even simpler total lack of `i18n`, since we don't actually change the
string at ally
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricato
ngraham added a comment.
Oops, thanks!
REPOSITORY
R134 Discover Software Store
BRANCH
clearer-update-text (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D13367
To: ngraham, apol, #discover_software_store
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezha
ngraham updated this revision to Diff 35803.
ngraham added a comment.
Use the simpler `i18n` function call
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13367?vs=35639&id=35803
BRANCH
clearer-update-text (branched from master)
REVISION
broulik added inline comments.
INLINE COMMENTS
> PackageKitResource.cpp:222
> foreach(const QString& pkgid, pkgids) {
> -ret += i18nc("package-name (version)", "%1 (%2)",
> PackageKit::Daemon::packageName(pkgid),
> PackageKit::Daemon::packageVersion(pkgid));
> +ret += i18nc
ngraham added a comment.
Does this work satisfactorily for you on Arch?
REPOSITORY
R134 Discover Software Store
BRANCH
clearer-update-text (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D13367
To: ngraham, apol, #discover_software_store
Cc: plasma-devel, ragreen, P
