D14905: Warn on logout screen when another user is logged in

2018-08-17 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG, harmathy. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we have a unified screen for logging out and shutting down, the hint is alway

D14905: Warn on logout screen when another user is logged in

2018-08-17 Thread Nathaniel Graham
ngraham added a comment. Big +1 for the concept. Only one string change proposal, down below: INLINE COMMENTS > Logout.qml:147 > +font.italic: true > +text: i18ndp("plasma_lookandfeel_org.kde.lookandfeel", "One > other user is currently logged in.", > +

D14905: Warn on logout screen when another user is logged in

2018-08-17 Thread David Edmundson
davidedmundson added a comment. When do we want unused sessions? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14905 To: broulik, #plasma, #vdg, harmathy Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreut

D14905: Warn on logout screen when another user is logged in

2018-08-17 Thread Kai Uwe Broulik
broulik added a comment. In D14905#310978 , @davidedmundson wrote: > When do we want unused sessions? Not sure. Does it recycle them or discard them after a while? They keep piling up usually .. REPOSITORY R120 Plasma Workspace REVIS

D14905: Warn on logout screen when another user is logged in

2018-08-20 Thread Marco Martin
mart added a comment. to expand on the concept, maybe could be nice as well a kauthorized key to actually letting only logout when there is somebody else logged in REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14905 To: broulik, #plasma, #vdg, harmathy Cc

D14905: Warn on logout screen when another user is logged in

2018-08-20 Thread Kai Uwe Broulik
broulik updated this revision to Diff 40042. broulik edited the test plan for this revision. broulik added a comment. - Update wording REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14905?vs=39938&id=40042 REVISION DETAIL https://phabricator.kde

D14905: Warn on logout screen when another user is logged in

2018-08-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. +1 shipit! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14905 To: broulik, #plasma, #vdg, harmathy, ngraham Cc: mart, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali

D14905: Warn on logout screen when another user is logged in

2018-08-20 Thread Nathaniel Graham
ngraham added a comment. In D14905#311825 , @mart wrote: > to expand on the concept, maybe could be nice as well a kauthorized key to actually letting only logout when there is somebody else logged in That would be appropriate for non-adm

D14905: Warn on logout screen when another user is logged in

2018-08-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:dd149d62b61c: Warn on logout screen when another user is logged in (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14905?vs=40042&id=

D14905: Warn on logout screen when another user is logged in

2018-08-20 Thread Andres Betts
abetts added a comment. This makes good sense in that admin world, more business style. I think they would appreciate it. I would probably look for a string that is a little shorter. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14905 To: broulik, #plasm