This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1692ae244bc5: Improve arrow key navigation of Kicker
search results (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15286?vs=41061&id=4109
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Much better, thanks! Verified that the bug is fixed now, and I can't find any
behavioral regressions.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.13
REVISION DETAIL
https://pha
hein updated this revision to Diff 41061.
hein added a comment.
Fix.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15286?vs=41036&id=41061
BRANCH
Plasma/5.13
REVISION DETAIL
https://phabricator.kde.org/D15286
AFFECTED FILES
applets/kicker/p
hein added a comment.
Indeed. Sorry, I introduced a small bug with a fatal copy and paste mistake
just before uploading.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D15286
To: hein, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Hmm, this doesn't quite fix the issue for me. After searching for something,
the top item in the list is still highlighted as before, but with this patch
when I press the down a
hein created this revision.
hein added a reviewer: ngraham.
Herald added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
Kicker already makes sure the first search result is highlighted
and actionable while searching. This patch makes arrow-down after
typing move
