D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

sdepiets abandoned this revision. sdepiets added a comment. In D15310#321238 , @davidedmundson wrote: > From the docs: > > By default, if CMAKE_MINIMUM_REQUIRED_VERSION is 3.1 or later, or if PKG_CONFIG_USE_CMAKE_PREFIX_PATH is set, the CMAK

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

davidedmundson added a comment. From the docs: By default, if CMAKE_MINIMUM_REQUIRED_VERSION is 3.1 or later, or if PKG_CONFIG_USE_CMAKE_PREFIX_PATH is set, the CMAKE_PREFIX_PATH, CMAKE_FRAMEWORK_PATH, and CMAKE_APPBUNDLE_PATH cache and environment variables will be added to pkg-config

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321234 , @sdepiets wrote: > Checking that Qt5Core version is initialized Sorry, but the whole change makes no sense, a big -1. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DE

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

sdepiets updated this revision to Diff 41092. sdepiets added a comment. Checking that Qt5Core version is initialized REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15310?vs=41087&id=41092 BRANCH cmake_qt5_default (branch

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321232 , @sdepiets wrote: > In D15310#321216 , @cgiboudeaux wrote: > > > In D15310#321210 , @davidedmundson wrote:

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

sdepiets added a comment. In D15310#321216 , @cgiboudeaux wrote: > In D15310#321210 , @davidedmundson wrote: > > > I have this in my dev setup > > > > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/op

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321210 , @davidedmundson wrote: > I have this in my dev setup > > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig > > If you had the equivalent, would you need this? Agreed,

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added inline comments. INLINE COMMENTS > FindQt5PlatformSupport.cmake:72 > +PATH_SUFFIXES > +QtPlatformSupport/${Qt5Core_VERSION}/ > ) This CMake module doesn't know Qt5Core_VERSION, this only works for you because there's a find_package(Qt5 ...) call before looking for

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

davidedmundson added a comment. I have this in my dev setup PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig If you had the equivalent, would you need this? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D15

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

sdepiets created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sdepiets requested review of this revision. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH cmake_qt5_default (branched from master) REVISION DETAIL https://phabricator