D15418: Dim application icon when it is not playing anything

broulik abandoned this revision. broulik added a comment. I'd prefer some dimmed label next to the app name but with the radio button and manual size calculations all over the place now, this is difficult REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D15418: Dim application icon when it is not playing anything

gvgeo added a comment. In D15418#604205 , @alexde wrote: > ...what about adding an overlay pause-icon, similar to D3302 ?... This could be interpreted as a button. Not that we removed the

D15418: Dim application icon when it is not playing anything

alexde added a comment. In D15418#604200 , @broulik wrote: > > Can't we dim label instead? > > I quite like that. Also not very obvious what it means, I guess.. Not sure if it was already discussed, but what about adding an overlay

D15418: Dim application icon when it is not playing anything

broulik added a comment. > Can't we dim label instead? I quite like that REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham,

D15418: Dim application icon when it is not playing anything

ngraham added a comment. @broulik Ping. :) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, Orage, LeGast00n,

D15418: Dim application icon when it is not playing anything

gvgeo added a comment. In D15418#331397 , @ngraham wrote: > Maybe something like this? > > F6283615: Screenshot_20180924_195355.png This feels too much. There is no need to be so obvious, just

D15418: Dim application icon when it is not playing anything

squeakypancakes added a comment. Could we just group them like we do on the devices tab? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham,

D15418: Dim application icon when it is not playing anything

broulik added a comment. Not a huge fan of this giant gap tbh REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D15418: Dim application icon when it is not playing anything

meven added a comment. In D15418#452214 , @meven wrote: > In D15418#364811 , @mart wrote: > > > In D15418#331397 , @ngraham wrote: > > > > > Maybe

D15418: Dim application icon when it is not playing anything

meven added a comment. In D15418#364811 , @mart wrote: > In D15418#331397 , @ngraham wrote: > > > Maybe something like this? > > > > F6283615: Screenshot_20180924_195355.png

D15418: Dim application icon when it is not playing anything

mart added a comment. In D15418#331397 , @ngraham wrote: > Maybe something like this? > > F6283615: Screenshot_20180924_195355.png I like this way REPOSITORY R115 Plasma Audio Volume Applet

D15418: Dim application icon when it is not playing anything

ngraham added a comment. Maybe something like this? F6283615: Screenshot_20180924_195355.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: svenmauch, acrouthamel,

D15418: Dim application icon when it is not playing anything

svenmauch added a comment. Ideally the volume lines would show how loud an application currently is by having an equalizer-like overlay on the blue volume bar. For now I think having the icons with less transparency is confusing. At least for me it doesn't seem intuitive enough what it

D15418: Dim application icon when it is not playing anything

acrouthamel added a comment. In D15418#325344 , @broulik wrote: > All of that is reserved for being "Muted". Just because it doesn't play something doesn't mean it couldn't start producing sound any moment. > We shouldn't use anything that

D15418: Dim application icon when it is not playing anything

abetts added a comment. In D15418#325344 , @broulik wrote: > All of that is reserved for being "Muted". Just because it doesn't play something doesn't mean it couldn't start producing sound any moment. > We shouldn't use anything that could

D15418: Dim application icon when it is not playing anything

broulik added a comment. All of that is reserved for being "Muted". Just because it doesn't play something doesn't mean it couldn't start producing sound any moment. We shouldn't use anything that could be confused as "muted" ("can never make any sound") for "not playing //currently//"

D15418: Dim application icon when it is not playing anything

ngraham added a comment. In D15418#325341 , @abetts wrote: > In D15418#325340 , @acrouthamel wrote: > > > How about changing the volume icon for the non-playing application to

D15418: Dim application icon when it is not playing anything

abetts added a comment. In D15418#325340 , @acrouthamel wrote: > How about changing the volume icon for the non-playing application to `audio-volume-muted.svg`? Then, when it is playing audio, it reverts to low/high icons as usual, based on

D15418: Dim application icon when it is not playing anything

acrouthamel added a comment. How about changing the volume icon for the non-playing application to `audio-volume-muted.svg`? Then, when it is playing audio, it reverts to low/high icons as usual, based on slider location. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D15418: Dim application icon when it is not playing anything

ngraham added a comment. Basically +1 on the concept, but I think we need to make the appearance a bit more distinct between playing vs non-playing. I've thrown out some ideas, and I'm open to others. Reducing the opacity even further would work. Adding a little tiny piece of text that says

D15418: Dim application icon when it is not playing anything

acrouthamel added a comment. I like it. I agree though to maybe make them a bit lighter. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: acrouthamel, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D15418: Dim application icon when it is not playing anything

ngraham added a comment. Hmm. Here's another idea: we could badge the app icon with `player-volume-muted`, maybe. I just worry a bit that lightening the app icon may be too subtle, and people might see it as a bug or wonder why it looks different. REPOSITORY R115 Plasma Audio Volume

D15418: Dim application icon when it is not playing anything

abetts added a comment. +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D15418: Dim application icon when it is not playing anything

broulik added a comment. F6252135: Screenshot_20180911_144651.png Fading the mute button doesn't make that big of a diference REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma,

D15418: Dim application icon when it is not playing anything

broulik added a comment. We need to take care to not make it confusing with the "muted" state where it fades the slider REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel,

D15418: Dim application icon when it is not playing anything

ngraham added a comment. That dimming effect might be too subtle on a brightly colored app icon. How about dimming the black volume icon instead of or in addition to the app icon? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik,

D15418: Dim application icon when it is not playing anything

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When a stream is present but not playing anything ("corked"), show icon slightly translucent