D15616: [Comic] Handle error state correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7c7c00798048: [comicprovider] Restart timer on redirect request (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. @davidedmundson to commit or you have other objections? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 43461. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42286=43461 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES dataengines/comic/comicprovider.cpp To: anthonyfieroni,

D15616: [Comic] Handle error state correctly

davidedmundson added a comment. yeah, that change in comicprovider I think makes sense. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. In D15616#341840 , @davidedmundson wrote: > The DataEngine also has a timer for timeouts, so we now have two timeout timers. > Having two timeout timers doesn't seem right. Yep, i'm on same opinion,

D15616: [Comic] Handle error state correctly

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > but in such cases dataUpdated is not called In what cases? The DataEngine also has a timer for timeouts, so we now have two timeout timers. Having

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Someone? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 42286. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42148=42286 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES applets/comic/comic.cpp applets/comic/comic.h

D15616: [Comic] Handle error state correctly

anthonyfieroni added a comment. Ping, @davidedmundson let's make some change on this REVISION DETAIL https://phabricator.kde.org/D15616 To: anthonyfieroni, davidedmundson, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 42148. anthonyfieroni added a comment. Stop indicator in a minute, restart engine in 10 sec. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=42035=42148 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 42035. anthonyfieroni added a comment. Another approach: If timer expires in 2 min without result disconnect it from source and starts again for next 2 min, when it expires if try to update again by activate slotCurrentDay REPOSITORY R114

D15616: [Comic] Handle error state correctly

anthonyfieroni updated this revision to Diff 41977. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15616?vs=41976=41977 REVISION DETAIL https://phabricator.kde.org/D15616 AFFECTED FILES applets/comic/comic.cpp applets/comic/comic.h

D15616: [Comic] Handle error state correctly

anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY This happen really rare, i've used comic applet on my desktop