D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Ambareesh Balaji
abalaji added a comment. @davidedmundson awesome! I've been running around in circles trying to find this, glad that you fixed it! Although I'm the future we should support this properly. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson, #plas

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Andres Betts
abetts added a comment. In D15942#337137 , @broulik wrote: > No, not with a finger or pen. We should support this, yes, but not in the way it's currently done by synthesized mouse events. Sounds good! Thanks for the update! REPOSITORY

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Kai Uwe Broulik
broulik added a comment. No, not with a finger or pen. We should support this, yes, but not in the way it's currently done by synthesized mouse events. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson, #plasma, broulik, ngraham Cc: abetts, rikm

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Andres Betts
abetts added a comment. Would this ensure that, at least, you can drag a window from the top area, like the toolbar, menu and the title bar empty areas? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson, #plasma, broulik, ngraham Cc: abetts, rik

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Kai Uwe Broulik
broulik added a comment. Probably needs an ifdef for `KDE4` REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15942 To: davidedmundson, #plasma, broulik, ngraham Cc: rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Rik Mills
rikmills added a comment. Fails to build on Neon and Kubuntu CI https://build.neon.kde.org/job/bionic_unstable_kde_breeze/71/ 01:20:12 [ 94%] Building CXX object kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o 01:20:12 kstyle/CMakeFiles/breeze.dir/build.make:982: recipe for

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-04 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R31:fb0cbedcc365: Don't drag windows in empty areas from touch/pen events (authored by davidedmundson). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15942?vs=42852&id=42

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-04 Thread Nathaniel Graham
ngraham added subscribers: abalaji, ngraham. ngraham accepted this revision. ngraham added a comment. Good idea. I know @abalaji was having trouble with this in D12162: Add support for touch scrolling in Dolphin . REPOSITORY R31 Breeze BRANCH master R

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-04 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY For a mouse users have the precision that if they clicked in an empty area