volkov closed this revision.
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D15946
To: volkov, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
volkov added inline comments.
INLINE COMMENTS
> broulik wrote in output.cpp:101
> The previous code also compared the contents of both, or does your new loop
> below do that?
Yes, the check is in the loop below: `after` and `before` are of the same
sizes, and if `after` contains each key from
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> output.cpp:101
> {
> -if (before.keys() != after.keys()) {
> +if (before.count() != after.count()) {
> return false;
The previous code also compared
volkov updated this revision to Diff 42860.
volkov added a comment.
fixed
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15946?vs=42859&id=42860
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15946
AFFECTED FILES
backends/kwayla
volkov added inline comments.
INLINE COMMENTS
> broulik wrote in waylandoutput.cpp:64
> I think we typically use `const...()` instead of `c...()` but since this
> method is `const`, shouldn't be neccessary to begin with
Isn't it better to follow STL style?
cbegin is also popular in KDE project
broulik added a comment.
Nice findings, feel free to ignore the stylistic changes I commented, except
the `qDeleteAll` one, and do unrelated further cleanup in a separate patch
INLINE COMMENTS
> waylandoutput.cpp:64
> +auto it = std::find(m_modeIdMap.cbegin(), m_modeIdMap.cend(),
> kway
volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.
REVISION SUMMARY
Found by clazy.
REPOSITORY
R110 KScreen Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15946
AFFECTED FI
