D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6a4f4cc31ebc: [Folder View] Improve layout, formatting, and wording of Icons and Locations… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

hein accepted this revision. hein added a comment. Looks great, I'm happy to finally see this get cleaned up. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg, hein, mart Cc: mart, abetts, thsurrel, plasma-devel, ragreen,

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

ngraham added a comment. @mart? Anyone in #plasma ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg, hein, mart Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot,

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

ngraham added a comment. @mart? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg, hein, mart Cc: mart, abetts, thsurrel, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

ngraham added a comment. @mart I've implemented your suggestions. To my eyes, the vertical spacing isn't enough. Compare the current version: F6344159: Using the correct objects.png ...With the previous one I had before: F6339576: Desktop icons

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

ngraham updated this revision to Diff 44089. ngraham added a comment. Implement @mart's suggestions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16241?vs=43959=44089 BRANCH icons-page-tweaks (branched from master) REVISION DETAIL

D16241: [Folder View] Improve layout, formatting, and wording of Icons and Locations pages

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ConfigIcons.qml:130 > > -// Row 1: Spacing > -Item { > -Layout.row: 1 > -Layout.column: 0 > -