D16284: do not force text display for ToolButton

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d37015a5d1b0: do not force text display for ToolButton (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16284?vs=45425=48915#toc REPOSITORY R858 Qt Quick Controls 2:

D16284: do not force text display for ToolButton

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Seems sensible. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH toolbutton REVISION DETAIL https://phabricator.kde.org/D16284 To: astippich, mart, apol,

D16284: do not force text display for ToolButton

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16284 To: astippich, mart, apol Cc: hein, mgallien, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16284: do not force text display for ToolButton

astippich updated this revision to Diff 45425. astippich added a comment. - follow style REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16284?vs=43823=45425 BRANCH toolbutton REVISION DETAIL

D16284: do not force text display for ToolButton

ngraham added a subscriber: hein. ngraham added a comment. To me, using `Qt::ToolButtonFollowStyle` would seem to make sense, but it might be best to ask @mart or @hein, who may know more of the history behind why `Qt::ToolButtonTextBesideIcon` was chosen here in the first place. REPOSITORY

D16284: do not force text display for ToolButton

astippich added a subscriber: mgallien. astippich added a comment. @mgallien stated in the meantime that we probably have been abusing the ToolButton in Elisa for our needs, and we will go a different route anyway. Since the desktop style still behaves differently than QQC1 and the Fusion

D16284: do not force text display for ToolButton

ngraham added a comment. Wouldn't this change make it revert to the default value, which is `Qt::ToolButtonIconOnly` ? How about `Qt::ToolButtonFollowStyle` instead? That way it'll pick up the user-overridable setting in the

D16284: do not force text display for ToolButton

astippich added a comment. opinions? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16284 To: astippich, mart, apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart