D16547: Connect slots explicitly instead of using auto-connections

2018-10-31 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D16547 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16547: Connect slots explicitly instead of using auto-connections

2018-10-31 Thread Alexander Volkov
volkov updated this revision to Diff 44551. volkov added a comment. rename slot REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16547?vs=44550&id=44551 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16547 AFFECTED FILE

D16547: Connect slots explicitly instead of using auto-connections

2018-10-31 Thread Alexander Volkov
volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Auto-connections is bad practice cause object renames break code and it can't be detected at compile time. REPOSITORY R121 Policy