D16587: [ksmserver] Simplify call to kcminit

2018-11-01 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R120:8c85bfa65a11: [ksmserver] Simplify call to kcminit (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16587: [ksmserver] Simplify call to kcminit

2018-11-01 Thread David Edmundson
davidedmundson updated this revision to Diff 44630. davidedmundson added a comment. remove Q_SIGNALS REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16587?vs=44628=44630 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16587

D16587: [ksmserver] Simplify call to kcminit

2018-11-01 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > main.h:37 > Q_SCRIPTABLE void runPhase2(); > -Q_SIGNALS: //dbus signal > - Q_SCRIPTABLE void phase1Done(); > - Q_SCRIPTABLE void phase2Done(); > +Q_SIGNALS: > public: It looks like there are no more signals anymore. Do

D16587: [ksmserver] Simplify call to kcminit

2018-11-01 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY kcminit had a slot to start processing something and a signal to emit when