D16595: Fix i18n when the kcm code is embedded in the plasmoid config

aacid closed this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16595 To: aacid, #plasma, davidedmundson, mart Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Sure, lets get this into stable till a magic fix comes along REPOSITORY R115 Plasma Audio Volume Applet BRANCH Plasma/5.14 REVISION DETAIL

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

aacid added a comment. ping? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16595 To: aacid, #plasma, davidedmundson, mart Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

aacid added a comment. Ok, understood, there's a plan to maybe make it work but isn't really working. Can i commit this today so it gets in Plasma 5.14.3 and our users get to understand the UI? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

broulik added a comment. We use everything in Plasma "as a library", that's why `KDeclarative::QmlObject` sets a translation context on the root context, so that plasmoids, wallpaper plugins, and other QML bits can use `i18n` with no translation domain (only exception really being the look

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

aacid added a comment. In D16595#352466 , @broulik wrote: > This is only covering an underlying problem where `KDeclarative` fails to set the translation context on `QQmlContext` as the engines are shared and it then refuses to set anything on

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

broulik added a comment. This is only covering an underlying problem where `KDeclarative` fails to set the translation context on `QQmlContext` as the engines are shared and it then refuses to set anything on the "internal context". But since I haven't found a solution, perhaps this is

D16595: Fix i18n when the kcm code is embedded in the plasmoid config

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY You can get to this code by right clicking on the plasmoid, when doing that the kcm translation catalog is not loaded so we must make