This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8c1fb20f52a5: Honor flat property of buttons (authored by
astippich).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
astippich added a comment.
friendly ping
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D16651
To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
astippich marked an inline comment as done.
astippich added a comment.
How can I actually run this test?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D16651
To: astippich, ngraham, mart, apol, #plasma
Cc: plasma-devel, ragreen, Pitel,
astippich updated this revision to Diff 44934.
astippich added a comment.
- do not unnecessarily check flat property
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16651?vs=44800=44934
BRANCH
flat
REVISION DETAIL
apol added a comment.
Looks good overall.
Maybe it would make sense to add a test in `tests/buttonIcons.qml`?
INLINE COMMENTS
> Button.qml:63
> +"iconColor": controlRoot.icon && controlRoot.icon.color.a > 0?
> controlRoot.icon.color : Kirigami.Theme.textColor,
> +
astippich created this revision.
astippich added reviewers: ngraham, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
astippich requested review of this revision.
REVISION SUMMARY
The flat property of buttons is currently not taken into
account for the desktop
