D16658: Respect the display property of buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R858:974efd584666: Respect the display property of buttons (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D16658: Respect the display property of buttons

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16658: Respect the display property of buttons

astippich added a comment. ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16658: Respect the display property of buttons

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16658: Respect the display property of buttons

astippich updated this revision to Diff 48917. astippich added a comment. - remove compatibility for Qt 5.9 and cleanup REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=46372=48917 BRANCH display_property REVISION

D16658: Respect the display property of buttons

astippich added a comment. ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16658: Respect the display property of buttons

astippich updated this revision to Diff 46372. astippich added a comment. - use hasOwnProperty and add fixme comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=45424=46372 BRANCH display_property REVISION DETAIL

D16658: Respect the display property of buttons

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Button.qml:44 > + * and controlRoot.display != AbstractButton.IconOnly == 0 */ > +Kirigami.MnemonicData.label: (controlRoot.display == undefined || >

D16658: Respect the display property of buttons

mart added a comment. In D16658#359049 , @astippich wrote: > Can I convince you to land this for Kf 5.53 with the promise to clean up once frameworks depends on Qt 5.10? it needs at least a final release of Qt 5.12: frameworks need to

D16658: Respect the display property of buttons

astippich added a comment. Can I convince you to land this for Kf 5.53 with the promise to clean up once frameworks depends on Qt 5.10? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To: astippich, #plasma, apol, mart Cc:

D16658: Respect the display property of buttons

astippich updated this revision to Diff 45424. astippich added a comment. - rebase - more verbose comment about compatibility REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16658?vs=44827=45424 REVISION DETAIL

D16658: Respect the display property of buttons

astippich added a comment. In D16658#354233 , @apol wrote: > I guess we can wait until we can bump to Qt 5.10 as a dependency? This looks a bit chaotic. > Also the Under/Beside setting isn't taken into account yet. Yep,

D16658: Respect the display property of buttons

apol added a comment. I guess we can wait until we can bump to Qt 5.10 as a dependency? This looks a bit chaotic. Also the Under/Beside setting isn't taken into account yet. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16658 To:

D16658: Respect the display property of buttons

astippich created this revision. astippich added reviewers: Plasma, apol, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Before, the display property of buttons introduced in Qt 5.10 was not taken