This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:fd19c36ec4e4: [comic] Request current identifier on data
change (authored by anthonyfieroni).
CHANGED PRIOR TO COMMIT
anthonyfieroni updated this revision to Diff 47418.
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16873?vs=47417=47418
REVISION DETAIL
https://phabricator.kde.org/D16873
AFFECTED FILES
applets/comic/comic.cpp
To: anthonyfieroni, #plasma,
anthonyfieroni updated this revision to Diff 47417.
anthonyfieroni added a comment.
Also fix max comic strips limit
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16873?vs=46207=47417
REVISION DETAIL
https://phabricator.kde.org/D16873
AFFECTED
anthonyfieroni added a comment.
I will push it in few days, since no activity.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D16873
To: anthonyfieroni, #plasma, davidedmundson, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
anthonyfieroni added a comment.
Ping
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D16873
To: anthonyfieroni, #plasma, davidedmundson, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
anthonyfieroni updated this revision to Diff 46207.
anthonyfieroni added a reviewer: mart.
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16873?vs=45444=46207
REVISION DETAIL
https://phabricator.kde.org/D16873
AFFECTED FILES
applets/comic/comic.cpp
anthonyfieroni added a comment.
@davidedmundson have more little fixes over applet did you something
suspicious here, i plan to commit them before 5.14.4 release.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D16873
To: anthonyfieroni, #plasma,
anthonyfieroni created this revision.
anthonyfieroni added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
anthonyfieroni requested review of this revision.
REVISION SUMMARY
The problem is when date is changed we connect to source ex.