This revision was automatically updated to reflect the committed changes.
Closed by commit R104:4a177884b052: [kded] Cleanup KScreenDaemon class
(authored by romangg).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16875?vs=45466&id=45469
REVISION DETAIL
ht
romangg updated this revision to Diff 45466.
romangg added a comment.
- Add back Q_SLOTS specifier to be sure
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16875?vs=45448&id=45466
BRANCH
codeCleanupExport
REVISION DETAIL
https://phabricator.kde.org/D
davidedmundson added inline comments.
INLINE COMMENTS
> romangg wrote in daemon.h:47
> Are you sure this is a problem? I just tested it manually with qdbusviewer
> and the method was called accordingly.
>
> Nowadays in Qt can't every function act as a slot, even without the Q_SLOTS
> specifier
broulik added inline comments.
INLINE COMMENTS
> romangg wrote in daemon.h:47
> Are you sure this is a problem? I just tested it manually with qdbusviewer
> and the method was called accordingly.
>
> Nowadays in Qt can't every function act as a slot, even without the Q_SLOTS
> specifier?
For
romangg added inline comments.
INLINE COMMENTS
> davidedmundson wrote in daemon.h:47
> this has moved from being a slot.
>
> If it is invoked from DBus as the comment suggests that will be a problem
Are you sure this is a problem? I just tested it manually with qdbusviewer and
the method was c
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> daemon.h:47
> +// DBus
> +void applyLayoutPreset(const QString &presetName);
> +
this has moved from being a slot.
If it is invoked f
romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.
REVISION SUMMARY
Do not export class, privatize and unvirtualize members.
Cleanup white space.
TEST PLAN
Manua
