D16879: [Login and Lock screens] Improve UI elements' contrast a bit

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d9532e80da6d: [Login and Lock screens] Improve UI elements' contrast a bit (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16879?vs=4

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham added a comment. Thanks @davidedmundson. @mart, is this okay now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16879 To: ngraham, davidedmundson, #vdg, #plasma Cc: mart, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham updated this revision to Diff 46365. ngraham added a comment. Revert unnecessary ActionButton shadows (will move into the other patch) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16879?vs=46364&id=46365 BRANCH lock-and-login-screen-co

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham updated this revision to Diff 46364. ngraham added a comment. Harmonize the clocks REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16879?vs=45962&id=46364 BRANCH lock-and-login-screen-contrast-tweaks (branched from master) REVISION DETAI

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham added inline comments. INLINE COMMENTS > mart wrote in ActionButton.qml:41 > those and the stronger shadows to the clock seems unrelated, as on this > contrast is doing by darkening the background and not adding unneeded shadows. > this seems more the unrelated change to the login screen

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

davidedmundson added a comment. Two really minor comments, but in general all seems good from my POV. +1 INLINE COMMENTS > Clock.qml:47 > +text: Qt.formatTime(timeSource.data["Local"]["DateTime"]) > +font.pointSize: 48 //Mockup says this, I'm not sure what to do? >

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham added a comment. @mart This was all specifically requested by @davidedmundson in D16031 , unless I misunderstood the request. @davidedmundson, can you clarify whether or not that is what you wanted? REPOSITORY R120 Plasma Workspace REVISION

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

mart added inline comments. INLINE COMMENTS > ActionButton.qml:41 > > -PlasmaCore.IconItem { > -id: icon > -anchors { > -top: parent.top > -horizontalCenter: parent.horizontalCenter > -} > -width: iconSize > -height: iconSize >

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

rooty added a comment. In D16879#362527 , @ngraham wrote: > IMHO spread 0.1 doesn't provide enough contrast against the toughest backgrounds: > > F6432627: Screenshot_20181119_124804.png ouch yo

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham updated this revision to Diff 45962. ngraham edited the test plan for this revision. ngraham added a comment. Slightly reduce shadow strength REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16879?vs=45833&id=45962 BRANCH lock-and-login-sc

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham updated this revision to Diff 45833. ngraham edited the test plan for this revision. ngraham added a comment. Tweak shadows REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16879?vs=45461&id=45833 BRANCH lock-and-login-screen-contrast-twea

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham added a comment. IMHO spread 0.1 doesn't provide enough contrast against the toughest backgrounds: F6432627: Screenshot_20181119_124804.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16879 To: ngraha

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

rooty added a comment. nice! i've been tinkering with this some more over the past few days (it's been driving me a little nuts), and i've been using "spread: 0.1" on the clock shadow while keeping "spread: 0.35" on the username and action button shadows i've been doing this because "0.35"

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham created this revision. ngraham added reviewers: davidedmundson, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As requested in D16031 , tweak the login