D16968: [Folder View] improve label contrast against challenging backgrounds

This revision was automatically updated to reflect the committed changes. Closed by commit R119:10278e79f116: [Folder View] improve label contrast against challenging backgrounds (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D16968: [Folder View] improve label contrast against challenging backgrounds

abetts added a comment. Looking good guys! +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: abetts, svenmauch, matheusm, filipf, emateli, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. Ah never mind, I see it now. Still, that's not connected to this patch, so let's try to keep the conversation on-topic. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: svenmauch,

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. Can't reproduce with Neon dev unstable / everything from git master. Then again I don't really see the problem in those screenshot in the first place. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein,

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. ^ Sorry to digress, but an update: bug does not happen if icons are in rows at the top (when the panel is at the bottom). We probably have bug with how the folder view widget adjusts the dimensions of its elements when it encounters panels or some other elements it

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. I've been testing this solution some more and I think I'm running into either a QML (using Qt 5.11.2) or widget bug, can someone else test to make sure it's not just my setup? Basically the text and the shadows can look hazy and unsharpened at times. The easiest

D16968: [Folder View] improve label contrast against challenging backgrounds

svenmauch added a comment. Looks great! Not having to avoid certain wallpapers is a big win for usability. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: svenmauch, matheusm, filipf, emateli, mart, plasma-devel,

D16968: [Folder View] improve label contrast against challenging backgrounds

matheusm added a comment. Much better now! +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: matheusm, filipf, emateli, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. Thanks! I like this too. Let's see if #VDG and/or #plasma folks agree. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma,

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. Looks great to me with your values! The shadows don't draw much attention and the labels are finally not wimpy looking in certain situations. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc:

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham updated this revision to Diff 46123. ngraham added a comment. Use a much tighter shadow that kind of looks like a tasteful outline REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16968?vs=46099=46123 BRANCH arcpatch-D16968 REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. Hey, that looks pretty darn good! I'll tweak the values a bit (just a bit) from what you suggested and rejigger this patch to use them. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc:

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. Ultimately if the blurriness can be resolved I'd recommend: horizontalOffset: 1 verticalOffset: 1 radius: 3 samples: 7 spread: 0.3 Before: F6439397: Screenshot_20181124_144817a.png After: F6439399:

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. Here's my rough estimation of what Windows does, although maybe a bit more subtly: horizontalOffset: 1 verticalOffset: 1 radius: 4 samples: 9 spread: 0.5 Before: F6439380: Screenshot_20181124_142255.png

D16968: [Folder View] improve label contrast against challenging backgrounds

filipf added a comment. The icon labels should be visible enough with pretty much any wallpaper used. Historically in other systems there's been some cheating involved by having default wallpapers deliberately be darker on the left side, but you'd think we could come up with something

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham updated this revision to Diff 46099. ngraham added a comment. Make the effect a bit more subtle REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16968?vs=45707=46099 BRANCH arcpatch-D16968 REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. That's a great point. In fact, now that I'm looking for it, I see that Windows uses a black outline on the white label text for their desktop icons. Unfortunately, the QML outline effect doesn't seem to look real good, at least not with the very small default

D16968: [Folder View] improve label contrast against challenging backgrounds

emateli added a comment. The classical solution to these problems is always a white text with black outline. Works well for both light and dark backgrounds. Some image from the internet: https://i.imgur.com/pQjoQ.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D16968: [Folder View] improve label contrast against challenging backgrounds

mart added a comment. tough now it looks a bit too much like a blur around the letters, rather than a shadow REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein, #vdg Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham added a comment. I can understand that. However, I think it's kind of a foul to change the UI such that the label becomes difficult to read with a lot of wallpapers, and then say, "just choose a better wallpaper." This isn't very respectful of our users, who I think should be

D16968: [Folder View] improve label contrast against challenging backgrounds

hein added a comment. Looks ugly to me. Honestly, my stance is "use a better wallpaper". There's only so far you can compromise theme aesthetics for other people's bad taste. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16968 To: ngraham, #plasma, hein,

D16968: [Folder View] improve label contrast against challenging backgrounds

ngraham created this revision. ngraham added reviewers: Plasma, hein, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently the shadow behind Folder View items' labels is very subtle. This leads to