D17192: use a Kirigami Heading for perfect consistency

ngraham added a comment. I see, you're right! Finally got to test this out instead of just complaining about the pictures. :) I now have `KDeclarative`, `KCMUtils`, and `KWidgetsAddons` with the necessary changes, but when I compile System Settings with this, I see the following:

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. In D17192#368233 , @ngraham wrote: > It isn't a title, though. At best, the text in question is a list item, not a title. It surely is, it's the title of that column and says, this column is stuff about "Fonts",

D17192: use a Kirigami Heading for perfect consistency

ngraham added a comment. It isn't a title, though. At best, the text in question is a list item, not a title. I kinda like the fact that the whole item is a button. It even looks button-like. Makes for a nice easy click/touch target, and you know exactly where going back will take you.

D17192: use a Kirigami Heading for perfect consistency

abetts added a comment. In D17192#368170 , @mart wrote: > well, to me part of the problem is that a title became a back button... even tough smaller target to hit, i would have preferred to have a toolbutton followed by a proper title that is

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. well, to me part of the problem is that a title became a back button... even tough smaller target to hit, i would have preferred to have a toolbutton followed by a proper title that is just a title REPOSITORY R124 System Settings REVISION DETAIL

D17192: use a Kirigami Heading for perfect consistency

ngraham added a comment. I agree with @abetts. The alignment changes are great, but I think it's a semantic error to use the title size and style for text that's essentially a glorified back button. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To:

D17192: use a Kirigami Heading for perfect consistency

abetts added a comment. I don't really have an issue with the font alignment. I think where I am conflicted is the part where we want this text to have too many purposes. The label is big so as to mean that it is a page title. However, when we place this on a phone, the header text is huge.

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. @abetts , @ngraham discuss :) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To: mart, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

abetts added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To: mart, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. anyways, this can wait/can be discussed, the ones instead i would like to get in soonish are D17190 and D17191 REPOSITORY R124 System Settings REVISION DETAIL

D17192: use a Kirigami Heading for perfect consistency

ngraham added a comment. I worry that this distorts the UI by giving the back button the same visual weight as the open KCM's title. I'm not categorically against it because I do see the advantage of improving the alignment, but something about it just feels kind of off to me in its current

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. F6443914: image.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D17192: use a Kirigami Heading for perfect consistency

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Make the title of the submodules column a Kirigami Heading so that looks the same and is perfectly